[Endpoint] Re-enable Functional test case for Endpoint related pages #68445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-tavares
added
v8.0.0
release_note:skip
1 task
Contributor
|
Pinging @elastic/endpoint-app-team (Feature:Endpoint) |
Contributor
|
Pinging @elastic/endpoint-management (Team:Endpoint Management) |
charlie-pichette
approved these changes
Jun 9, 2020
Contributor
charlie-pichette
left a comment
charlie-pichette
left a comment
There was a problem hiding this comment.
The tests look good @paul-tavares.
…le-functional-tests
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
kevinlog
reviewed
Jun 9, 2020
|
|
||
| // FLAKY: https://github.com/elastic/kibana/issues/63621 | ||
| describe.skip('host list', function () { | ||
| describe.skip('endpoint list', function () { |
Contributor
There was a problem hiding this comment.
should this still be skipped?
Contributor
Author
There was a problem hiding this comment.
@kevinlog yes. Although I updated the tests with new paths, etc. they are still "flaky" - @charlie-pichette is (will) working on getting them reenabled. :)
kevinlog
reviewed
Jun 9, 2020
| loadTestFile(require.resolve('./resolver')); | ||
| loadTestFile(require.resolve('./policy_details')); | ||
|
|
||
| // loadTestFile(require.resolve('./alerts')); |
Contributor
There was a problem hiding this comment.
small nit, we could add a TODO or just remove the commented out code and track enabling the rest of the tests in another ticket
Contributor
Author
There was a problem hiding this comment.
Good idea. I will remove the commented out code in a subsquent PR and will create an Issue to follow up on it (I don't think these are applicable anymore)
paul-tavares
added a commit
to paul-tavares/kibana
that referenced
this pull request
Jun 9, 2020
…lastic#68445) * Improve Policy test service provider - Added `getFullAgentConfig()` to Endpoint Policy Test data provider service * enable Policy List functional tests * Added Policy Details Tests * Add test ids to policy detail Max and Linux forms * Added page objects utilities and moved `clickOnEuiCheckbox` there # Conflicts: # x-pack/test/functional_endpoint/apps/endpoint/index.ts
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jun 10, 2020
* master: (22 commits) Partial revert of "Sync Kerberos + Anonymous access tests with the latest `security/_authenticate` API (user roles now include roles of anonymous user)." (elastic#68624) adapt some snapshot test (elastic#68489) [APM] Service maps - Fix missing ML status for services with jobs but no anomalies (elastic#68486) [skip test] apis Kerberos security Kerberos authentication finishing SPNEGO should properly set cookie and authenticate user [SIEM][Exceptions] - ExceptionsViewer UI component part 2 (elastic#68294) Surface data streams in Index Management. (elastic#67806) Fix edit datasource not working following changes in elastic#67234 (elastic#68583) [Logs + Metrics UI] Clean up async plugin initialization (elastic#67654) APM Storybook fixes (elastic#68671) Upgrade EUI to v24.1.0 (elastic#68141) [ML] DF Analytics: Creation wizard part 2 (elastic#68462) [Uptime] Fix race on overview page query (elastic#67843) Prefer using npm_execpath when spawning Yarn (elastic#68673) [Security] [Cases] Attach timeline to existing case (elastic#68580) Use Search API in Vega (elastic#68257) [Component templates] Table view (elastic#68031) [Uptime] Added relative date info in cert status column (elastic#67612) [Endpoint] Re-enable Functional test case for Endpoint related pages (elastic#68445) run page_load_metrics tests in visual regresssion jobs (elastic#68570) Enable exhaustive-deps; correct any lint warnings (elastic#68453) ...
paul-tavares
added a commit
that referenced
this pull request
Jun 10, 2020
…68445) (#68699) * Improve Policy test service provider - Added `getFullAgentConfig()` to Endpoint Policy Test data provider service * enable Policy List functional tests * Added Policy Details Tests * Add test ids to policy detail Max and Linux forms * Added page objects utilities and moved `clickOnEuiCheckbox` there # Conflicts: # x-pack/test/functional_endpoint/apps/endpoint/index.ts Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Also:
Fixes #66579
Fixes #66465
Checklist