[Uptime] Added relative date info in cert status column #67612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
Team:Uptime - DEPRECATED
Contributor
|
Pinging @elastic/uptime (Team:uptime) |
shahzad31
changed the title
shahzad31
added
release_note:skip
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
justinkambic
reviewed
Jun 3, 2020
Contributor
justinkambic
left a comment
justinkambic
left a comment
There was a problem hiding this comment.
This looks great, had a few comments/asks.
| </span> | ||
| </EuiHealth> | ||
| ); | ||
| } |
Contributor
There was a problem hiding this comment.
Was it a deliberate choice to omit the relative date from CERT_STATUS.TOO_OLD case?
Contributor
Author
There was a problem hiding this comment.
i took care of it.
| return ( | ||
| <EuiHealth color="success"> | ||
| <span>{labels.OK}</span> | ||
| <span> |
Contributor
There was a problem hiding this comment.
This needs to be translated, something like:
Suggested change
| <span> | |
| <span> | |
| {labels.OK} | |
| <DateText color="subdued" size="xs"> | |
| <FormattedMessage | |
| id="xpack.uptime.certs.status.ok" | |
| defaultMessage=" for {okRelativeDate}" | |
| description={ | |
| 'Denotes an amount of time for which a cert is valid. Example: "OK for 2 days"' | |
| } | |
| values={{ | |
| okRelativeDate, | |
| }} | |
| /> | |
| </DateText> | |
| </span> |
Alternatively you could extract the string to a label, but seems strange to do it for only one word.
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jun 10, 2020
* master: (22 commits) Partial revert of "Sync Kerberos + Anonymous access tests with the latest `security/_authenticate` API (user roles now include roles of anonymous user)." (elastic#68624) adapt some snapshot test (elastic#68489) [APM] Service maps - Fix missing ML status for services with jobs but no anomalies (elastic#68486) [skip test] apis Kerberos security Kerberos authentication finishing SPNEGO should properly set cookie and authenticate user [SIEM][Exceptions] - ExceptionsViewer UI component part 2 (elastic#68294) Surface data streams in Index Management. (elastic#67806) Fix edit datasource not working following changes in elastic#67234 (elastic#68583) [Logs + Metrics UI] Clean up async plugin initialization (elastic#67654) APM Storybook fixes (elastic#68671) Upgrade EUI to v24.1.0 (elastic#68141) [ML] DF Analytics: Creation wizard part 2 (elastic#68462) [Uptime] Fix race on overview page query (elastic#67843) Prefer using npm_execpath when spawning Yarn (elastic#68673) [Security] [Cases] Attach timeline to existing case (elastic#68580) Use Search API in Vega (elastic#68257) [Component templates] Table view (elastic#68031) [Uptime] Added relative date info in cert status column (elastic#67612) [Endpoint] Re-enable Functional test case for Endpoint related pages (elastic#68445) run page_load_metrics tests in visual regresssion jobs (elastic#68570) Enable exhaustive-deps; correct any lint warnings (elastic#68453) ...
shahzad31
added a commit
to shahzad31/kibana
that referenced
this pull request
Jun 11, 2020
Co-authored-by: Elastic Machine <[email protected]>
shahzad31
added a commit
that referenced
this pull request
Jun 11, 2020
#68875) Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: elastic/uptime#216
Added related date info in cert status column to provide user more context about the validity date.