[Uptime] Add loading message for monitor list no items#67378
Merged
justinkambic merged 4 commits intoelastic:masterfrom Jun 3, 2020
Merged
Conversation
justinkambic
added
bug
Contributor
|
Pinging @elastic/uptime (Team:uptime) |
justinkambic
added
the
release_note:skip
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
shahzad31
approved these changes
Jun 3, 2020
Contributor
shahzad31
left a comment
shahzad31
left a comment
There was a problem hiding this comment.
LGTM, tested and it displays loading now.
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
This was referenced Jun 3, 2020
justinkambic
added a commit
to justinkambic/kibana
that referenced
this pull request
Jun 3, 2020
* Add loading message for monitor list no items. * Add tests. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
justinkambic
added a commit
to justinkambic/kibana
that referenced
this pull request
Jun 3, 2020
* Add loading message for monitor list no items. * Add tests. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
justinkambic
added a commit
that referenced
this pull request
Jun 4, 2020
* Add loading message for monitor list no items. * Add tests. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Contributor
Author
justinkambic
added a commit
that referenced
this pull request
Jun 4, 2020
* Add loading message for monitor list no items. * Add tests. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jun 4, 2020
…ms-column * 'master' of github.com:elastic/kibana: (63 commits) remove scripts. prettire update has been done (elastic#68130) Closes elastic#68055 by detecting the local Kibana version and using that as (elastic#68198) [apm] docs: add deployment annotation example (elastic#67408) [ML] Extend population preview chart to show actual and typical value (elastic#67569) Refactor index management client integration tests for scalability (elastic#67917) Add generator function that creates multiple alerts (elastic#67713) chore(NA): remove config arg from os packages (elastic#67871) [Reporting] Move code out of Legacy (elastic#67904) [Metrics UI] Add overrides to Snapshot API to support alert previews (elastic#68125) [Security] [Cases] Manage timeline UI API (elastic#67719) [ENDPOINT][INGEST]Task/endpoint ingest update (elastic#67234) Fix code coverage for jest, upload merged reports (elastic#68149) Update documentation/examples of deprecated namespaceAgnostic field (elastic#68039) [DOCS] Updates Canvas docs with new menus (elastic#66061) chore(NA): avoids imports of server or public code into common (elastic#67231) [SIEM] Fix GetOneTimeline graphql type (elastic#68137) skip flaky suite (elastic#67838) [Uptime] Add loading message for monitor list no items (elastic#67378) [Ingest Manager] Update indexing strategy docs to use dataset.* (elastic#68068) [Ingest Manager] Fix datasource validation for streams without vars (elastic#67950) ... # Conflicts: # x-pack/plugins/index_management/__jest__/client_integration/helpers/index.ts # x-pack/plugins/index_management/__jest__/client_integration/home.test.ts # x-pack/plugins/index_management/__jest__/client_integration/home/index_templates_tab.helpers.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves elastic/uptime#207.
When the Uptime app's monitor list component is loading, it should not display "No monitors found", especially as an initial message.