chore(NA): avoids imports of server or public code into common by mistic · Pull Request #67231 · elastic/kibana

mistic · 2020-05-21T23:27:38Z

There is a compliment to other PRs previously opened #67152 and #67149.

It adds an eslint rule to prevent server or public code to be imported into common code.

elasticmachine · 2020-05-21T23:27:41Z

Pinging @elastic/kibana-operations (Team:Operations)

elasticmachine · 2020-05-21T23:27:43Z

Pinging @elastic/apm-ui (Team:apm)

nreese

maps changes LGTM
code review

...lugins/infra/common/inventory_models/shared/components/metrics_and_groupby_toolbar_items.tsx

legrego

Security/Spaces changes LGTM

.eslintrc.js

Co-authored-by: Ryland Herrick <ryalnd@gmail.com>

mistic · 2020-05-26T17:22:58Z

@elastic/kibana-app-arch @elastic/apm-ui @elastic/logs-metrics-ui @elastic/endpoint-app-team can I get a code owners review here please? 😃

smith

APM changes look good. Thanks for doing this.

weltenwort

infra plugin changes LGTM

lizozom

@elastic/kibana-app-arch LGTM

lizozom · 2020-05-31T13:13:06Z

@elasticmachine merge upstream

…blic-code

mistic · 2020-06-01T18:26:08Z

@elasticmachine merge upstream

…blic-code

… module

mistic · 2020-06-03T16:24:56Z

@elasticmachine merge upstream

…blic-code

mistic · 2020-06-03T17:26:18Z

@elasticmachine merge upstream

…blic-code

kibanamachine · 2020-06-03T19:16:41Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: e60f18d

History

💚 Build #51459 succeeded a7e8ff1
💚 Build #50927 succeeded a64fd35
💔 Build #50885 failed ee7c88b
💔 Build #50731 failed e7fca2f
💚 Build #49812 succeeded f93370e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

mistic · 2020-06-03T19:22:49Z

7.x: cd79116
7.8: 289e1c8

…ic#67231) * chore(NA): avoids imports of server or public code into common * chore(NA): fix imports from public or server into common * chore(NA): fix typechecking for data plugin stubs * chore(NA): fix types and tests related with licensing plugin * chore(NA): fix problems on infra plugin * chore(NA): fix typo on .eslintrc.js Co-authored-by: Ryland Herrick <ryalnd@gmail.com> * chore(NA): migrate to license mock usage on security plugin licensing module Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Ryland Herrick <ryalnd@gmail.com>

…ic#67231) * chore(NA): avoids imports of server or public code into common * chore(NA): fix imports from public or server into common * chore(NA): fix typechecking for data plugin stubs * chore(NA): fix types and tests related with licensing plugin * chore(NA): fix problems on infra plugin * chore(NA): fix typo on .eslintrc.js Co-authored-by: Ryland Herrick <ryalnd@gmail.com> * chore(NA): migrate to license mock usage on security plugin licensing module Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Ryland Herrick <ryalnd@gmail.com> # Conflicts: # x-pack/plugins/infra/common/inventory_models/shared/components/metrics_and_groupby_toolbar_items.tsx # x-pack/plugins/maps/common/descriptor_types/data_request_descriptor_types.d.ts # x-pack/plugins/security/common/licensing/license_service.test.ts # x-pack/plugins/spaces/common/licensing/license_service.test.ts

… (#68168) * chore(NA): avoids imports of server or public code into common * chore(NA): fix imports from public or server into common * chore(NA): fix typechecking for data plugin stubs * chore(NA): fix types and tests related with licensing plugin * chore(NA): fix problems on infra plugin * chore(NA): fix typo on .eslintrc.js Co-authored-by: Ryland Herrick <ryalnd@gmail.com> * chore(NA): migrate to license mock usage on security plugin licensing module Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Ryland Herrick <ryalnd@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Ryland Herrick <ryalnd@gmail.com>

…67231) (#68175) * chore(NA): avoids imports of server or public code into common (#67231) * chore(NA): avoids imports of server or public code into common * chore(NA): fix imports from public or server into common * chore(NA): fix typechecking for data plugin stubs * chore(NA): fix types and tests related with licensing plugin * chore(NA): fix problems on infra plugin * chore(NA): fix typo on .eslintrc.js Co-authored-by: Ryland Herrick <ryalnd@gmail.com> * chore(NA): migrate to license mock usage on security plugin licensing module Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Ryland Herrick <ryalnd@gmail.com> # Conflicts: # x-pack/plugins/infra/common/inventory_models/shared/components/metrics_and_groupby_toolbar_items.tsx # x-pack/plugins/maps/common/descriptor_types/data_request_descriptor_types.d.ts # x-pack/plugins/security/common/licensing/license_service.test.ts # x-pack/plugins/spaces/common/licensing/license_service.test.ts * chore(NA): fix eslint problems

…ms-column * 'master' of github.com:elastic/kibana: (63 commits) remove scripts. prettire update has been done (elastic#68130) Closes elastic#68055 by detecting the local Kibana version and using that as (elastic#68198) [apm] docs: add deployment annotation example (elastic#67408) [ML] Extend population preview chart to show actual and typical value (elastic#67569) Refactor index management client integration tests for scalability (elastic#67917) Add generator function that creates multiple alerts (elastic#67713) chore(NA): remove config arg from os packages (elastic#67871) [Reporting] Move code out of Legacy (elastic#67904) [Metrics UI] Add overrides to Snapshot API to support alert previews (elastic#68125) [Security] [Cases] Manage timeline UI API (elastic#67719) [ENDPOINT][INGEST]Task/endpoint ingest update (elastic#67234) Fix code coverage for jest, upload merged reports (elastic#68149) Update documentation/examples of deprecated namespaceAgnostic field (elastic#68039) [DOCS] Updates Canvas docs with new menus (elastic#66061) chore(NA): avoids imports of server or public code into common (elastic#67231) [SIEM] Fix GetOneTimeline graphql type (elastic#68137) skip flaky suite (elastic#67838) [Uptime] Add loading message for monitor list no items (elastic#67378) [Ingest Manager] Update indexing strategy docs to use dataset.* (elastic#68068) [Ingest Manager] Fix datasource validation for streams without vars (elastic#67950) ... # Conflicts: # x-pack/plugins/index_management/__jest__/client_integration/helpers/index.ts # x-pack/plugins/index_management/__jest__/client_integration/home.test.ts # x-pack/plugins/index_management/__jest__/client_integration/home/index_templates_tab.helpers.ts

mistic added 2 commits May 21, 2020 22:42

chore(NA): avoids imports of server or public code into common

79de8f9

chore(NA): fix imports from public or server into common

1347567

mistic added chore Team:Operations Kibana-Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v7.8.1 labels May 21, 2020

mistic requested a review from a team May 21, 2020 23:27

mistic requested review from a team as code owners May 21, 2020 23:27

botelastic bot added Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Team:APM - DEPRECATED Use Team:obs-ux-infra_services. labels May 21, 2020

mistic removed Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Team:APM - DEPRECATED Use Team:obs-ux-infra_services. labels May 21, 2020

chore(NA): fix typechecking for data plugin stubs

58a4c21

botelastic bot added Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Team:APM - DEPRECATED Use Team:obs-ux-infra_services. labels May 22, 2020

nreese approved these changes May 22, 2020

View reviewed changes

mistic added 2 commits May 22, 2020 02:33

chore(NA): fix types and tests related with licensing plugin

f88dd79

chore(NA): fix problems on infra plugin

d33114f

mistic commented May 22, 2020

View reviewed changes

...lugins/infra/common/inventory_models/shared/components/metrics_and_groupby_toolbar_items.tsx Show resolved Hide resolved

mistic removed Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Team:APM - DEPRECATED Use Team:obs-ux-infra_services. labels May 22, 2020

legrego approved these changes May 26, 2020

View reviewed changes

rylnd approved these changes May 26, 2020

View reviewed changes

rylnd reviewed May 26, 2020

View reviewed changes

.eslintrc.js Outdated Show resolved Hide resolved

chore(NA): fix typo on .eslintrc.js

f93370e

Co-authored-by: Ryland Herrick <ryalnd@gmail.com>

botelastic bot added Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Team:APM - DEPRECATED Use Team:obs-ux-infra_services. labels May 26, 2020

smith approved these changes May 26, 2020

View reviewed changes

weltenwort approved these changes May 28, 2020

View reviewed changes

lizozom approved these changes May 29, 2020

View reviewed changes

Merge branch 'master' into prevent-common-code-to-import-server-or-pu…

e7fca2f

…blic-code

elasticmachine and others added 2 commits June 1, 2020 11:26

Merge branch 'master' into prevent-common-code-to-import-server-or-pu…

ee7c88b

…blic-code

chore(NA): migrate to license mock usage on security plugin licensing…

a64fd35

… module

oatkiller approved these changes Jun 2, 2020

View reviewed changes

Merge branch 'master' into prevent-common-code-to-import-server-or-pu…

a7e8ff1

…blic-code

Merge branch 'master' into prevent-common-code-to-import-server-or-pu…

e60f18d

…blic-code

mistic merged commit 20d6082 into elastic:master Jun 3, 2020

mistic mentioned this pull request Jun 3, 2020

[7.x] chore(NA): avoids imports of server or public code into common (#67231) #68168

Merged

mistic mentioned this pull request Jun 3, 2020

[7.8] chore(NA): avoids imports of server or public code into common (#67231) #68175

Merged

Conversation

mistic commented May 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented May 21, 2020

Uh oh!

elasticmachine commented May 21, 2020

Uh oh!

nreese left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

legrego left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mistic commented May 26, 2020

Uh oh!

smith left a comment

Choose a reason for hiding this comment

Uh oh!

weltenwort left a comment

Choose a reason for hiding this comment

Uh oh!

lizozom left a comment

Choose a reason for hiding this comment

Uh oh!

lizozom commented May 31, 2020

Uh oh!

mistic commented Jun 1, 2020

Uh oh!

mistic commented Jun 3, 2020

Uh oh!

mistic commented Jun 3, 2020

Uh oh!

kibanamachine commented Jun 3, 2020

💚 Build Succeeded

History

Uh oh!

mistic commented Jun 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

mistic commented May 21, 2020 •

edited

Loading

mistic commented Jun 3, 2020 •

edited

Loading