Ignore OS-specific files in other operating systems

[bevacqua]

Fixes #4460

[epixa]

Since you are doing all of these in sequence and you have a single error handler for everything, I recommend replacing the promise chaining and built in this.async behavior with native (transpiled) async/await.

[bevacqua]

Let me know if there's a bluebird method for this (I couldn't find one). Not that used to converting callbacks into promises

[epixa]

jenkins, test it

[epixa]

I don't think you need to wrap this in a new function, you can just make the overall task function async:

grunt.registerTask('_build:osShellScripts', async function () {
  const done = this.async();
  // ...
  try {
    await allPlatforms(platform => punlink(join(platform.buildDir, 'bin')));
    await allPlatforms(platform => pncp(source, join(platform.buildDir, 'bin')));
    await allPlatforms(removeExtraneousShellScripts);
    done();
  } catch (e) {
    done(e);
  }
});

[bevacqua]

Not sure what this meant

jenkins, test it

[bevacqua]

There we go. Pulled all the functions outside, code looks pretty good now 🎉

I didn't know I could just make the exported function async, so thanks for pointing that out.

[epixa]

jenkins, test it triggers a new jenkins build.

[epixa]

And apparently it triggers a new build even when done inside a code block.

[epixa]

This looks great! LGTM

[tsullivan]

And apparently it triggers a new build even when done inside a code block.
LOL

LGTM!