Upgrade EUI to v74.0.1 by cee-chen · Pull Request #149457 · elastic/kibana

cee-chen · 2023-01-24T21:21:26Z

Summary

eui@73.0.0 ⏩ eui@74.0.1

`74.0.1`

Bug fixes

Fixed EuiModalHeaderTitle type errors when passed EuiTitle props (#6547)

`74.0.0`

Added the component prop to EuiModalHeaderTitle, which allows overriding the default h1 tag (#6530)
Added the titleProps prop to EuiConfirmModal, which allows overriding the default h1 tag (#6530)

Bug fixes

Fixed slight row height jumping in EuiBasicTables when actions with tooltips became disabled (#6538)

Breaking changes

EuiModalHeaderTitle now always wraps its children in a h1 tag (previously attempted to conditionally detect whether its children were raw strings or not). To change this tag type to, e.g. a more generic div, use the new component prop. (#6530)
EuiLink now applies rel="noreferrer" to all domains, including elastic.co (#6535)
EuiBasicTable no longer blocks mouse/keyboard interactions while loading (#6543)

CSS-in-JS conversions

Converted EuiBasicTable to Emotion (#6539)
Added a new RenderWithEuiTheme render prop utility (#6539)

- EuiModalHeaderTitle now automatically wraps contents in `h1` by default

- use the new `component` prop instead

- `EuiFlexGroups` should be used directly below `EuiModalHeader`, not `EuiModalHeaderTitle`, which should only be wrapped around the actual title + `EuiModalHeaderTitle` now uses `EuiTitle` under the hood, so remove explicit `EuiTitle` usages in favor of modal titles

- all links, including `elastic.co`, now generate `rel=noreferrer`

- to account for Emotion conversion

- this is due to the presence of a new `RenderWithEuiTheme` render prop around the table body - workarounds are to either use `.render()` and DOM-esque queries, or to use `.renderProp` to dive into the table body

cee-chen · 2023-01-25T04:10:59Z

Synthetics tests seem to be hanging/stalling out, but I don't anticipate them failing (unless they time out, in which case I'll re-run), so going to go ahead and mark this PR as ready for review.

stratoula

Visualizations team changes LGTM!

x-pack/plugins/apm/public/components/app/service_groups/service_group_save/select_services.tsx

nreese

kibana-gis changes LGTM
code review

jennypavlova

Stack Monitoring changes LGTM!

kpollich

Fleet changes

kpatticha

APM changes LGTM 🥳

Thanks

cee-chen · 2023-01-25T20:38:58Z

@elasticmachine merge upstream

TinaHeiligers

core-related changes are super small and LGTM!

mattkime

changes lgtm!

walterra

ML related changes LGTM, checked all modals.

cee-chen · 2023-01-26T17:24:01Z

@elasticmachine merge upstream

cee-chen · 2023-01-26T17:24:56Z

Thanks everyone for the thorough QA and reviews so far!

@elastic/response-ops @elastic/security-solution-platform @elastic/security-threat-hunting-explore, as a heads up, I'll be asking for an admin merge by EOD tomorrow (Friday). Please take a second to review changes affecting your code (either EuiModalHeaderTitle related, or snapshot updates) if you can!

cee-chen · 2023-01-27T17:18:21Z

@elasticmachine merge upstream

kibana-ci · 2023-01-27T17:46:26Z

💛 Build succeeded, but was flaky

Failed CI Steps

Security Solution Tests #3

Test Failures

[job] [logs] Security Solution Tests #3 / Timelines Creates a timeline by clicking untitled timeline from bottom bar can be added notes

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`infra`	1242	1241	-1
`visTypeVega`	293	292	-1
total			-2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	3.3MB	3.3MB	+14.0B
`canvas`	1022.3KB	1022.3KB	-13.0B
`dashboard`	364.1KB	364.0KB	-20.0B
`dataViewManagement`	116.2KB	116.2KB	-25.0B
`enterpriseSearch`	2.1MB	2.1MB	-50.0B
`fleet`	923.0KB	922.9KB	-58.0B
`infra`	1.3MB	1.3MB	-222.0B
`maps`	2.7MB	2.7MB	-13.0B
`ml`	3.4MB	3.4MB	-621.0B
`monitoring`	452.1KB	452.1KB	-25.0B
`securitySolution`	12.8MB	12.8MB	-158.0B
`triggersActionsUi`	724.6KB	724.5KB	-76.0B
`unifiedSearch`	263.9KB	263.8KB	-50.0B
`visTypeVega`	1.8MB	1.8MB	-223.0B
`visualizations`	258.2KB	258.1KB	-75.0B
total			-1.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`embeddable`	69.2KB	69.2KB	-7.0B
`kbnUiSharedDeps-css`	321.2KB	320.8KB	-387.0B
`kbnUiSharedDeps-npmDll`	5.3MB	5.3MB	+466.0B
`savedObjects`	29.2KB	29.2KB	-25.0B
total			+47.0B

History

💛 Build #103088 was flaky 8153606
💚 Build #102781 succeeded 608b447
💔 Build #102726 failed 18ad40d
💛 Build #102422 was flaky f2f2ad6
💔 Build #102388 failed fa9db5ff5158f766a90702fbe02f1ab2c4bf3478

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @cee-chen

## Summary `eui@73.0.0` ⏩ `eui@74.0.1` --- ## [`74.0.1`](https://github.com/elastic/eui/tree/v74.0.1) **Bug fixes** - Fixed `EuiModalHeaderTitle` type errors when passed `EuiTitle` props ([elastic#6547](elastic/eui#6547)) ## [`74.0.0`](https://github.com/elastic/eui/tree/v74.0.0) - Added the `component` prop to `EuiModalHeaderTitle`, which allows overriding the default `h1` tag ([elastic#6530](elastic/eui#6530)) - Added the `titleProps` prop to `EuiConfirmModal`, which allows overriding the default `h1` tag ([elastic#6530](elastic/eui#6530)) **Bug fixes** - Fixed slight row height jumping in `EuiBasicTable`s when actions with tooltips became disabled ([elastic#6538](elastic/eui#6538)) **Breaking changes** - `EuiModalHeaderTitle` now **always** wraps its children in a `h1` tag (previously attempted to conditionally detect whether its children were raw strings or not). To change this tag type to, e.g. a more generic `div`, use the new `component` prop. ([elastic#6530](elastic/eui#6530)) - `EuiLink` now applies `rel="noreferrer"` to all domains, including `elastic.co` ([elastic#6535](elastic/eui#6535)) - `EuiBasicTable` no longer blocks mouse/keyboard interactions while `loading` ([elastic#6543](elastic/eui#6543)) **CSS-in-JS conversions** - Converted `EuiBasicTable` to Emotion ([elastic#6539](elastic/eui#6539)) - Added a new `RenderWithEuiTheme` render prop utility ([elastic#6539](elastic/eui#6539)) --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

cee-chen changed the title ~~Upgrade EUI to v74.0.0~~ Upgrade EUI to v74.0.1 Jan 24, 2023

Upgrade to v74.0.1

4b394fc

cee-chen force-pushed the eui-v74.0.x branch from 4318541 to fa9db5f Compare January 24, 2023 23:18

cee-chen added 8 commits January 24, 2023 17:54

[EuiModalHeaderTitle] Remove instances of nested h1 tags

bfb13b8

- EuiModalHeaderTitle now automatically wraps contents in `h1` by default

[EuiModalHeaderTitle] Convert instances of nested h2 tags

c1c896b

- use the new `component` prop instead

[EuiModalHeaderTitle] Convert instances of nested h3 tags

42647c4

- use the new `component` prop instead

[getSecureRelForTarget] Update failing test to account for new behavior

b67d09b

[EuiLink] Update snapshots with new rel behavior

090408a

- all links, including `elastic.co`, now generate `rel=noreferrer`

[EuiBasicTable] Update snapshots

6adddc9

- to account for Emotion conversion

[EuiBasicTable] Fix shallow enzyme tests not able to reach into table

f2f2ad6

- this is due to the presence of a new `RenderWithEuiTheme` render prop around the table body - workarounds are to either use `.render()` and DOM-esque queries, or to use `.renderProp` to dive into the table body

cee-chen force-pushed the eui-v74.0.x branch from fa9db5f to f2f2ad6 Compare January 25, 2023 01:54

cee-chen marked this pull request as ready for review January 25, 2023 04:11

cee-chen requested review from a team as code owners January 25, 2023 04:11

cee-chen requested a review from a team January 25, 2023 04:11

cee-chen requested review from a team as code owners January 25, 2023 04:11

cee-chen requested a review from a team January 25, 2023 04:11

cee-chen requested review from a team as code owners January 25, 2023 04:11

stratoula approved these changes Jan 25, 2023

View reviewed changes

sabarasaba approved these changes Jan 25, 2023

View reviewed changes

kpatticha requested changes Jan 25, 2023

View reviewed changes

x-pack/plugins/apm/public/components/app/service_groups/service_group_save/select_services.tsx Show resolved Hide resolved

nreese approved these changes Jan 25, 2023

View reviewed changes

jennypavlova approved these changes Jan 25, 2023

View reviewed changes

dhurley14 requested a review from nkhristinin January 25, 2023 17:47

[PR feedback] Fix APM select services modal header

18ad40d

kpollich approved these changes Jan 25, 2023

View reviewed changes

cee-chen requested a review from kpatticha January 25, 2023 18:12

kpatticha approved these changes Jan 25, 2023

View reviewed changes

shahzad31 approved these changes Jan 25, 2023

View reviewed changes

cee-chen self-assigned this Jan 25, 2023

Merge branch 'main' into eui-v74.0.x

608b447

TinaHeiligers approved these changes Jan 25, 2023

View reviewed changes

mattkime approved these changes Jan 25, 2023

View reviewed changes

mistic approved these changes Jan 26, 2023

View reviewed changes

vadimkibana approved these changes Jan 26, 2023

View reviewed changes

walterra approved these changes Jan 26, 2023

View reviewed changes

Merge branch 'main' into eui-v74.0.x

8153606

nkhristinin approved these changes Jan 27, 2023

View reviewed changes

Merge branch 'main' into eui-v74.0.x

9e731fa

jbudz merged commit 8a2ecc3 into elastic:main Jan 27, 2023

cee-chen deleted the eui-v74.0.x branch January 27, 2023 19:24

Conversation

cee-chen commented Jan 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

74.0.1

74.0.0

Uh oh!

cee-chen commented Jan 25, 2023

Uh oh!

stratoula left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nreese left a comment

Choose a reason for hiding this comment

Uh oh!

jennypavlova left a comment

Choose a reason for hiding this comment

Uh oh!

kpollich left a comment

Choose a reason for hiding this comment

Uh oh!

kpatticha left a comment

Choose a reason for hiding this comment

Uh oh!

cee-chen commented Jan 25, 2023

Uh oh!

TinaHeiligers left a comment

Choose a reason for hiding this comment

Uh oh!

mattkime left a comment

Choose a reason for hiding this comment

Uh oh!

walterra left a comment

Choose a reason for hiding this comment

Uh oh!

cee-chen commented Jan 26, 2023

Uh oh!

cee-chen commented Jan 26, 2023

Uh oh!

cee-chen commented Jan 27, 2023

Uh oh!

kibana-ci commented Jan 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants

cee-chen commented Jan 24, 2023 •

edited

Loading

`74.0.1`

`74.0.0`

kibana-ci commented Jan 27, 2023 •

edited

Loading