[Metrics UI] Require filterQuery to be ES JSON #64937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zacqary
added
Feature:Alerting
Feature:Metrics UI
Contributor
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
Zacqary
force-pushed
the
64832-kql-handler-remove
branch
from
0afe09e to
518cee2
Compare
…-remove # Conflicts: # x-pack/plugins/infra/server/lib/alerting/metric_threshold/register_metric_threshold_alert_type.ts # x-pack/test/api_integration/apis/infra/metrics_alerting.ts
simianhacker
approved these changes
May 4, 2020
Member
simianhacker
left a comment
simianhacker
left a comment
There was a problem hiding this comment.
LGTM... I like how the validation takes care of the filter query, it's smart.
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Zacqary
added a commit
to Zacqary/kibana
that referenced
this pull request
May 5, 2020
# Conflicts: # x-pack/plugins/infra/server/lib/alerting/inventory_metric_threshold/register_inventory_metric_threshold_alert_type.ts # x-pack/plugins/infra/server/lib/alerting/metric_threshold/metric_threshold_executor.ts # x-pack/plugins/infra/server/lib/alerting/metric_threshold/register_metric_threshold_alert_type.ts # x-pack/test/api_integration/apis/infra/metrics_alerting.ts
Zacqary
added a commit
to Zacqary/kibana
that referenced
this pull request
May 5, 2020
Zacqary
added a commit
that referenced
this pull request
May 6, 2020
Co-authored-by: Elastic Machine <[email protected]>
This was referenced May 7, 2020
Zacqary
added a commit
to Zacqary/kibana
that referenced
this pull request
May 7, 2020
Zacqary
added a commit
that referenced
this pull request
May 8, 2020
Co-authored-by: Elastic Machine <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #64832
Alert executor will now only accept filterQuery in a parseable Elasticsearch JSON format. It will validate it at creation time.
Checklist