[Canvas] Adds edit menu by cqliu1 · Pull Request #64738 · elastic/kibana

cqliu1 · 2020-04-29T03:19:02Z

Summary

Related to #35873.

This changes the element options menu from the right sidebar into an edit menu in the Canvas top menu.

This menu is context aware and will enable certain menu options only when those actions make sense.

Examples

No elements selected and no stored paste data

Every option except Undo and Redo are disabled

No elements selected with stored paste data

Paste is enabled

Single element selected

Group, Alignment, and Distribution are disabled

Single grouped element selected

Order, Alignment, and Distribution are disabled

Two elements selected

Order and Distribution are disabled

Three or more elements selected

Order is disabled

Changes:

moves element options menu from SidebarHeader to EditMenu
adds Undo and Redo options to the edit menu
converts SidebarHeader from a class component to a function component
removes title from ShareMenu context menu to reduce redundancy

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility, including a check against IE11

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2020-04-29T16:18:52Z

Pinging @elastic/kibana-canvas (Team:Canvas)

ryankeairns

LGTM. Design looks spot on, all functionality works as expected. Well done!

crob611

Looks good 👍

cqliu1 · 2020-04-30T18:49:17Z

@elasticmachine merge upstream

kibanamachine · 2020-05-01T00:21:06Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 738b9d8

History

💚 Build #44569 succeeded 738b9d8
💚 Build #44006 succeeded 3cb2453
💔 Build #43978 failed 8489ba5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* upstream/master: (315 commits) [APM] Fix failing `ApmIndices` test (elastic#64965) [APM] Fix paths for ts optimization script (elastic#65012) Use HDR for percentiles (elastic#64758) [EPM] fix updates available filter (elastic#64957) [Uptime] Certificates page (elastic#64059) load lens app lazily (elastic#64769) [legacy/server/config] remove unnecessary deps for simple helper (elastic#64954) Fixed alert Edit flyout shows the error message when one of this actions has a preconfigured action type (elastic#64742) [data.search.aggs] Remove legacy aggs APIs. (elastic#64719) Fixed `AddAlert` flyout does not immediately update state to reflect new props (elastic#64927) [Discover] Show doc viewer action buttons on focus (elastic#64912) [EPM] restrict package install endpoint from installing/updating to old packages (elastic#64932) [Metrics UI] Add inventory metric threshold alerts (elastic#64292) [Canvas] Adds edit menu (elastic#64738) [Canvas] Adds refresh and autoplay options to view menu (elastic#64375) [Lens] Trigger a filter action on click in datatable visualization (elastic#63840) [SIEM][CASE] Refactor Connectors - Jira Connector (elastic#63450) [APM] Client new platform migration (elastic#64046) [Monitoring] NP Migration complete client cutover (elastic#62908) Ingest Node Pipelines UI (elastic#62321) ...

…or-part-mvp-2 * 'master' of github.com:elastic/kibana: (51 commits) [APM] Fix failing `ApmIndices` test (elastic#64965) [APM] Fix paths for ts optimization script (elastic#65012) Use HDR for percentiles (elastic#64758) [EPM] fix updates available filter (elastic#64957) [Uptime] Certificates page (elastic#64059) load lens app lazily (elastic#64769) [legacy/server/config] remove unnecessary deps for simple helper (elastic#64954) Fixed alert Edit flyout shows the error message when one of this actions has a preconfigured action type (elastic#64742) [data.search.aggs] Remove legacy aggs APIs. (elastic#64719) Fixed `AddAlert` flyout does not immediately update state to reflect new props (elastic#64927) [Discover] Show doc viewer action buttons on focus (elastic#64912) [EPM] restrict package install endpoint from installing/updating to old packages (elastic#64932) [Metrics UI] Add inventory metric threshold alerts (elastic#64292) [Canvas] Adds edit menu (elastic#64738) [Canvas] Adds refresh and autoplay options to view menu (elastic#64375) [Lens] Trigger a filter action on click in datatable visualization (elastic#63840) [SIEM][CASE] Refactor Connectors - Jira Connector (elastic#63450) [APM] Client new platform migration (elastic#64046) [Monitoring] NP Migration complete client cutover (elastic#62908) Ingest Node Pipelines UI (elastic#62321) ... # Conflicts: # x-pack/plugins/ingest_pipelines/common/types.ts # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_form/pipeline_form.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_form/pipeline_form_fields.tsx # x-pack/plugins/ingest_pipelines/public/shared_imports.ts

* master: (44 commits) onEvent prop for expression component (elastic#64995) [APM] Fix failing `ApmIndices` test (elastic#64965) [APM] Fix paths for ts optimization script (elastic#65012) Use HDR for percentiles (elastic#64758) [EPM] fix updates available filter (elastic#64957) [Uptime] Certificates page (elastic#64059) load lens app lazily (elastic#64769) [legacy/server/config] remove unnecessary deps for simple helper (elastic#64954) Fixed alert Edit flyout shows the error message when one of this actions has a preconfigured action type (elastic#64742) [data.search.aggs] Remove legacy aggs APIs. (elastic#64719) Fixed `AddAlert` flyout does not immediately update state to reflect new props (elastic#64927) [Discover] Show doc viewer action buttons on focus (elastic#64912) [EPM] restrict package install endpoint from installing/updating to old packages (elastic#64932) [Metrics UI] Add inventory metric threshold alerts (elastic#64292) [Canvas] Adds edit menu (elastic#64738) [Canvas] Adds refresh and autoplay options to view menu (elastic#64375) [Lens] Trigger a filter action on click in datatable visualization (elastic#63840) [SIEM][CASE] Refactor Connectors - Jira Connector (elastic#63450) [APM] Client new platform migration (elastic#64046) [Monitoring] NP Migration complete client cutover (elastic#62908) ...

Added edit menu

8489ba5

cqliu1 added the WIP Work in progress label Apr 29, 2020

cqliu1 added 3 commits April 28, 2020 23:40

Fixed custom element functional tests

d61358d

Removed title from element_menu

744d4e0

Updated snapshots

3cb2453

cqliu1 added impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v7.8.0 v8.0.0 labels Apr 29, 2020

cqliu1 added review enhancement New value added to drive a business result release_note:enhancement and removed WIP Work in progress labels Apr 29, 2020

cqliu1 marked this pull request as ready for review April 29, 2020 16:21

cqliu1 requested a review from a team as a code owner April 29, 2020 16:21

ryankeairns self-requested a review April 29, 2020 17:47

ryankeairns approved these changes Apr 29, 2020

View reviewed changes

crob611 approved these changes Apr 30, 2020

View reviewed changes

Merge branch 'master' into canvas/edit-menu

738b9d8

cqliu1 merged commit f9c1033 into elastic:master Apr 30, 2020

cqliu1 deleted the canvas/edit-menu branch April 30, 2020 21:51

cqliu1 mentioned this pull request Apr 30, 2020

[7.x] [Canvas] Adds edit menu (#64738) #64973

Merged

cqliu1 added a commit to cqliu1/kibana that referenced this pull request Apr 30, 2020

[Canvas] Adds edit menu (elastic#64738)

1c52838

cqliu1 mentioned this pull request Apr 30, 2020

[Canvas] Top menu as links vs icons #35873

Closed

7 tasks

cqliu1 added a commit that referenced this pull request May 1, 2020

[7.x] [Canvas] Adds edit menu (#64738) (#64973)

43c692d

KOTungseth mentioned this pull request May 11, 2020

[DOCS] Updates Canvas docs with new menus #66061

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Canvas] Adds edit menu#64738

[Canvas] Adds edit menu#64738
cqliu1 merged 5 commits intoelastic:masterfrom
cqliu1:canvas/edit-menu

cqliu1 commented Apr 29, 2020 •

edited

Loading

Uh oh!

elasticmachine commented Apr 29, 2020

Uh oh!

ryankeairns left a comment

Uh oh!

crob611 left a comment

Uh oh!

cqliu1 commented Apr 30, 2020

Uh oh!

kibanamachine commented May 1, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

cqliu1 commented Apr 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Examples

No elements selected and no stored paste data

No elements selected with stored paste data

Single element selected

Single grouped element selected

Two elements selected

Three or more elements selected

Checklist

For maintainers

Uh oh!

elasticmachine commented Apr 29, 2020

Uh oh!

ryankeairns left a comment

Choose a reason for hiding this comment

Uh oh!

crob611 left a comment

Choose a reason for hiding this comment

Uh oh!

cqliu1 commented Apr 30, 2020

Uh oh!

kibanamachine commented May 1, 2020

💚 Build Succeeded

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

cqliu1 commented Apr 29, 2020 •

edited

Loading