[Monitoring] NP Migration complete client cutover by igoristic · Pull Request #62908 · elastic/kibana

igoristic · 2020-04-08T07:06:50Z

This is the complete NP cutover phase for the Stack Monitoring client

Fix all jest/linting tests
Removed all unused legacy files
Move all files outside the legacy directory

…ady_3

…ady_3_backup

elasticmachine · 2020-04-08T07:06:52Z

Pinging @elastic/stack-monitoring (Team:Monitoring)

jasonrhodes · 2020-04-20T21:29:09Z

@igoristic what's still left with this PR? Anything you need help with?

…ady_final

igoristic · 2020-04-21T04:34:36Z

What's still left with this PR? Anything you need help with?

@jasonrhodes Not much left, just need to merge the rest of my branches and fix some conflicts with master.

I think I'm good (for now), this shouldn't take long, but will definitely reach out if I get stuck. Thanks for the offer 🙇

…ady_final

x-pack/legacy/plugins/monitoring/public/components/alerts/alerts.js

…ady_final

joshdover

High level review and manual testing LGTM

kibanamachine · 2020-04-30T18:30:25Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 076aa6c

History

💚 Build #43583 succeeded 4b0ec8e
💚 Build #43306 succeeded ceb888c
💚 Build #43235 succeeded d2df9c0
💚 Build #42907 succeeded bc02938
💔 Build #42754 failed 15578d7

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

snide

Looks like moves mostly. LGTM on the sass side. Small comment for a later PR.

snide · 2020-04-30T19:57:33Z

x-pack/plugins/monitoring/public/angular/app_modules.ts

+// required for `ngSanitize` angular module
+import 'angular-sanitize';
+import 'angular-route';
+import '../index.scss';


Consider breaking this up (in a later PR). You can now import the individual sass files directly into the component themselves import './my_component.scss. Otherwise the entirety of the the css loads at once. Just helps with performance.

Will do, Thank you!

* Final phase before the complete cutover * NP migration * lint fix * More NP stuff * Moved Stack Monitoring client plugin outside legacy and fixed all tests * ... * Removed unused files * Fix for main links * Fixed more tests * Fixed redirect when clicking on SM icon again * Code review feedback * Addressed code review feedback * Fixed return value # Conflicts: # .github/CODEOWNERS # x-pack/legacy/plugins/monitoring/public/components/license/index.js # x-pack/plugins/monitoring/public/components/beats/listing/listing.js

* upstream/master: (315 commits) [APM] Fix failing `ApmIndices` test (elastic#64965) [APM] Fix paths for ts optimization script (elastic#65012) Use HDR for percentiles (elastic#64758) [EPM] fix updates available filter (elastic#64957) [Uptime] Certificates page (elastic#64059) load lens app lazily (elastic#64769) [legacy/server/config] remove unnecessary deps for simple helper (elastic#64954) Fixed alert Edit flyout shows the error message when one of this actions has a preconfigured action type (elastic#64742) [data.search.aggs] Remove legacy aggs APIs. (elastic#64719) Fixed `AddAlert` flyout does not immediately update state to reflect new props (elastic#64927) [Discover] Show doc viewer action buttons on focus (elastic#64912) [EPM] restrict package install endpoint from installing/updating to old packages (elastic#64932) [Metrics UI] Add inventory metric threshold alerts (elastic#64292) [Canvas] Adds edit menu (elastic#64738) [Canvas] Adds refresh and autoplay options to view menu (elastic#64375) [Lens] Trigger a filter action on click in datatable visualization (elastic#63840) [SIEM][CASE] Refactor Connectors - Jira Connector (elastic#63450) [APM] Client new platform migration (elastic#64046) [Monitoring] NP Migration complete client cutover (elastic#62908) Ingest Node Pipelines UI (elastic#62321) ...

…or-part-mvp-2 * 'master' of github.com:elastic/kibana: (51 commits) [APM] Fix failing `ApmIndices` test (elastic#64965) [APM] Fix paths for ts optimization script (elastic#65012) Use HDR for percentiles (elastic#64758) [EPM] fix updates available filter (elastic#64957) [Uptime] Certificates page (elastic#64059) load lens app lazily (elastic#64769) [legacy/server/config] remove unnecessary deps for simple helper (elastic#64954) Fixed alert Edit flyout shows the error message when one of this actions has a preconfigured action type (elastic#64742) [data.search.aggs] Remove legacy aggs APIs. (elastic#64719) Fixed `AddAlert` flyout does not immediately update state to reflect new props (elastic#64927) [Discover] Show doc viewer action buttons on focus (elastic#64912) [EPM] restrict package install endpoint from installing/updating to old packages (elastic#64932) [Metrics UI] Add inventory metric threshold alerts (elastic#64292) [Canvas] Adds edit menu (elastic#64738) [Canvas] Adds refresh and autoplay options to view menu (elastic#64375) [Lens] Trigger a filter action on click in datatable visualization (elastic#63840) [SIEM][CASE] Refactor Connectors - Jira Connector (elastic#63450) [APM] Client new platform migration (elastic#64046) [Monitoring] NP Migration complete client cutover (elastic#62908) Ingest Node Pipelines UI (elastic#62321) ... # Conflicts: # x-pack/plugins/ingest_pipelines/common/types.ts # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_form/pipeline_form.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_form/pipeline_form_fields.tsx # x-pack/plugins/ingest_pipelines/public/shared_imports.ts

* master: (44 commits) onEvent prop for expression component (elastic#64995) [APM] Fix failing `ApmIndices` test (elastic#64965) [APM] Fix paths for ts optimization script (elastic#65012) Use HDR for percentiles (elastic#64758) [EPM] fix updates available filter (elastic#64957) [Uptime] Certificates page (elastic#64059) load lens app lazily (elastic#64769) [legacy/server/config] remove unnecessary deps for simple helper (elastic#64954) Fixed alert Edit flyout shows the error message when one of this actions has a preconfigured action type (elastic#64742) [data.search.aggs] Remove legacy aggs APIs. (elastic#64719) Fixed `AddAlert` flyout does not immediately update state to reflect new props (elastic#64927) [Discover] Show doc viewer action buttons on focus (elastic#64912) [EPM] restrict package install endpoint from installing/updating to old packages (elastic#64932) [Metrics UI] Add inventory metric threshold alerts (elastic#64292) [Canvas] Adds edit menu (elastic#64738) [Canvas] Adds refresh and autoplay options to view menu (elastic#64375) [Lens] Trigger a filter action on click in datatable visualization (elastic#63840) [SIEM][CASE] Refactor Connectors - Jira Connector (elastic#63450) [APM] Client new platform migration (elastic#64046) [Monitoring] NP Migration complete client cutover (elastic#62908) ...

* Final phase before the complete cutover * NP migration * lint fix * More NP stuff * Moved Stack Monitoring client plugin outside legacy and fixed all tests * ... * Removed unused files * Fix for main links * Fixed more tests * Fixed redirect when clicking on SM icon again * Code review feedback * Addressed code review feedback * Fixed return value # Conflicts: # .github/CODEOWNERS # x-pack/legacy/plugins/monitoring/public/components/license/index.js # x-pack/plugins/monitoring/public/components/beats/listing/listing.js

kibanamachine · 2020-05-05T16:58:45Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

) * [Monitoring] NP Migration complete client cutover (#62908) * Final phase before the complete cutover * NP migration * lint fix * More NP stuff * Moved Stack Monitoring client plugin outside legacy and fixed all tests * ... * Removed unused files * Fix for main links * Fixed more tests * Fixed redirect when clicking on SM icon again * Code review feedback * Addressed code review feedback * Fixed return value # Conflicts: # .github/CODEOWNERS # x-pack/legacy/plugins/monitoring/public/components/license/index.js # x-pack/plugins/monitoring/public/components/beats/listing/listing.js * Fixed conflicts Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

igoristic · 2020-05-05T18:28:29Z

Backport:
7.x: 1ec28fd

igoristic added 7 commits March 25, 2020 04:53

Final phase before the complete cutover

6d3d1a9

Merge branch 'master' of https://github.com/elastic/kibana into np_re…

71b7d49

…ady_3

Merge branch 'master' of https://github.com/elastic/kibana into np_re…

ed94446

…ady_3

Merge branch 'master' of https://github.com/elastic/kibana into np_re…

4471d02

…ady_3

NP migration

a082e94

Merge branch 'master' of https://github.com/elastic/kibana into np_re…

aba1cce

…ady_3_backup

lint fix

ce397b3

igoristic added Team:Monitoring Stack Monitoring team v8.0.0 labels Apr 8, 2020

This was referenced Apr 14, 2020

Migrate logstash frontend to KP #63417

Merged

Refactor logstash -> monitoring dependency to use plugin contracts instead of HTTP #63931

Closed

Merge branch 'master' of https://github.com/elastic/kibana into np_re…

5f10444

…ady_final

igoristic added 2 commits April 22, 2020 05:04

More NP stuff

2de9011

Merge branch 'master' of https://github.com/elastic/kibana into np_re…

9a1fca3

…ady_final

igoristic requested review from a team, chrisronline and joshdover April 22, 2020 09:27

igoristic marked this pull request as ready for review April 22, 2020 09:28

igoristic requested a review from a team as a code owner April 22, 2020 09:28

igoristic added release_note:skip Skip the PR/issue when compiling release notes v7.7.1 labels Apr 22, 2020

chrisronline reviewed Apr 22, 2020

View reviewed changes

x-pack/legacy/plugins/monitoring/public/components/alerts/alerts.js Show resolved Hide resolved

cchaos requested a review from andreadelrio April 22, 2020 13:59

igoristic added 4 commits April 22, 2020 14:23

Merge branch 'master' of https://github.com/elastic/kibana into np_re…

d07305f

…ady_final

Moved Stack Monitoring client plugin outside legacy and fixed all tests

a66c9ca

...

27c9ded

Merge branch 'master' of https://github.com/elastic/kibana into np_re…

bf6e693

…ady_final

Merge branch 'master' of https://github.com/elastic/kibana into np_re…

4b0ec8e

…ady_final

igoristic requested a review from joshdover April 27, 2020 23:05

Fixed return value

b862136

joshdover mentioned this pull request Apr 30, 2020

[Canvas] Finish moving UI to Kibana Platform #64831

Merged

igoristic added 2 commits April 30, 2020 11:59

Merge branch 'master' of https://github.com/elastic/kibana into np_re…

fd68442

…ady_final

Merge branch 'master' of https://github.com/elastic/kibana into np_re…

076aa6c

…ady_final

joshdover approved these changes Apr 30, 2020

View reviewed changes

snide approved these changes Apr 30, 2020

View reviewed changes

igoristic merged commit 59315bc into elastic:master Apr 30, 2020

igoristic deleted the np_ready_final branch April 30, 2020 19:59

sorenlouv mentioned this pull request May 1, 2020

[7.x] [Monitoring] NP Migration complete client cutover (#62908) #64991

Closed

igoristic mentioned this pull request May 4, 2020

[7.x] [Monitoring] NP Migration complete client cutover (#62908) #65113

Closed

igoristic added v7.8.0 and removed v7.7.1 labels May 4, 2020

igoristic mentioned this pull request May 4, 2020

[7.x] [Monitoring] NP Migration complete client cutover (#62908) #65144

Merged

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 5, 2020

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 5, 2020

igoristic added the backported label May 5, 2020

chrisronline mentioned this pull request Jun 12, 2020

Unexpected behavior when enabling stack monitoring on ESS #68933

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Monitoring] NP Migration complete client cutover#62908

[Monitoring] NP Migration complete client cutover#62908
igoristic merged 29 commits intoelastic:masterfrom
igoristic:np_ready_final

igoristic commented Apr 8, 2020 •

edited

Loading

Uh oh!

elasticmachine commented Apr 8, 2020

Uh oh!

jasonrhodes commented Apr 20, 2020

Uh oh!

igoristic commented Apr 21, 2020

Uh oh!

Uh oh!

joshdover left a comment

Uh oh!

kibanamachine commented Apr 30, 2020

Uh oh!

snide left a comment

Uh oh!

snide Apr 30, 2020

Uh oh!

igoristic Apr 30, 2020

Uh oh!

kibanamachine commented May 5, 2020

Uh oh!

igoristic commented May 5, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Conversation

igoristic commented Apr 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Apr 8, 2020

Uh oh!

jasonrhodes commented Apr 20, 2020

Uh oh!

igoristic commented Apr 21, 2020

Uh oh!

Uh oh!

joshdover left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Apr 30, 2020

💚 Build Succeeded

History

Uh oh!

snide left a comment

Choose a reason for hiding this comment

Uh oh!

snide Apr 30, 2020

Choose a reason for hiding this comment

Uh oh!

igoristic Apr 30, 2020

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented May 5, 2020

Uh oh!

igoristic commented May 5, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

igoristic commented Apr 8, 2020 •

edited

Loading