Skip to content

Index pattern management UI -> TypeScript and New Platform Ready (edit_index_pattern)#64184

Merged
VladLasitsa merged 11 commits intoelastic:masterfrom
VladLasitsa:#51332(edit_index_pattern)
Apr 24, 2020
Merged

Index pattern management UI -> TypeScript and New Platform Ready (edit_index_pattern)#64184
VladLasitsa merged 11 commits intoelastic:masterfrom
VladLasitsa:#51332(edit_index_pattern)

Conversation

@VladLasitsa
Copy link
Copy Markdown
Contributor

@VladLasitsa VladLasitsa commented Apr 22, 2020 •
edited
Loading

Part of #51322

Summary

Converted edit_index_pattern to React. Created a separate component for tabs. Removed field_controls.html because it is no longer used

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@VladLasitsa VladLasitsa requested a review from alexwizp April 22, 2020 13:38
@VladLasitsa VladLasitsa self-assigned this Apr 22, 2020
@VladLasitsa
Copy link
Copy Markdown
Contributor Author

VladLasitsa commented Apr 22, 2020

@elasticmachine merge upstream

@VladLasitsa VladLasitsa requested a review from mattkime April 23, 2020 13:54
mattkime
mattkime approved these changes Apr 23, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@mattkime mattkime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mattkime mattkime marked this pull request as ready for review April 23, 2020 22:19
@mattkime mattkime requested a review from a team as a code owner April 23, 2020 22:19
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 23, 2020

Pinging @elastic/kibana-app-arch (Team:AppArch)

@mattkime mattkime added Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages release_note:skip Skip the PR/issue when compiling release notes labels Apr 23, 2020
@mattkime mattkime mentioned this pull request Apr 24, 2020
Closed
16 tasks
alexwizp
alexwizp approved these changes Apr 24, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@alexwizp alexwizp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested locally

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 24, 2020

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@VladLasitsa VladLasitsa merged commit 66074f9 into elastic:master Apr 24, 2020
@VladLasitsa VladLasitsa mentioned this pull request Apr 24, 2020
Merged
VladLasitsa added a commit to VladLasitsa/kibana that referenced this pull request Apr 24, 2020
@VladLasitsa @elasticmachine @mattkime
Index pattern management UI -> TypeScript and New Platform Ready (edi…
d74c662 
…t_index_pattern) (elastic#64184)

* draft

* Converted edit_index_pattern to React. Created 'tab' component.

* Some fixes

* returned state_container

* Fixed tests and translation

* Some refactoring

* Fixed tests

* rermove unused translations

* update snapshots

* Some refactoring

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Matt Kime <matt@mattki.me>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Apr 27, 2020
@jloleysens
Merge branch 'feature/ingest-node-pipelines' of github.com:elastic/ki…
42247e2 
…bana into ingest-node-pipeline/open-flyout-create-edit

* 'feature/ingest-node-pipelines' of github.com:elastic/kibana: (116 commits)
  [Ingest Node Pipelines] More lenient treatment of on-failure value (elastic#64411)
  Report Deletion via UI- functional test (elastic#64031)
  Bump handlebars dependency from 4.5.3 to 4.7.6 (elastic#64402)
  [Uptime] Update TLS settings (elastic#64111)
  [alerting] removes usage of any throughout Alerting Services code (elastic#64161)
  [CANVAS] Moves notify to a canvas service (elastic#63268)
  [Canvas] Misc NP Stuff (elastic#63703)
  update apm index pattern (elastic#64232)
  Task/hostlist pagination (elastic#63722)
  [NP] Vega migration (elastic#63849)
  Move ensureDefaultIndexPattern into data plugin (elastic#63100)
  [Fleet] Fix agent status count to not include unenrolled agents (elastic#64106)
  Migrate graph_workspace saved object registration to Kibana platform (elastic#64157)
  Index pattern management UI -> TypeScript and New Platform Ready (edit_index_pattern) (elastic#64184)
  [ML] EuiDataGrid ml/transform components. (elastic#63447)
  [ML] Moving to kibana capabilities (elastic#64057)
  Move input_control_vis into NP (elastic#63333)
  remove reference to local application service in graph (elastic#64288)
  KQL removes leading zero and breaks query (elastic#62748)
  [FieldFormats] Cleanup: rename IFieldFormatType -> FieldFormatInstanceType (elastic#64193)
  ...
mattkime pushed a commit that referenced this pull request Apr 28, 2020
@VladLasitsa
[7.x] Index pattern management UI -> TypeScript and New Platform Read…
5817db8 
…y (edit_index_pattern) (#64184) (#64419)

* Index pattern management UI -> TypeScript and New Platform Ready (edit_index_pattern) (#64184)
@mattkime mattkime mentioned this pull request May 5, 2020
Merged
@mattkime mattkime mentioned this pull request Jun 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattkime mattkime mattkime approved these changes

@alexwizp alexwizp alexwizp approved these changes

Assignees

@VladLasitsa VladLasitsa

Labels

Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@VladLasitsa @elasticmachine @kibanamachine @mattkime @alexwizp