Move input_control_vis into NP#63333
Merged
sulemanof merged 4 commits intoelastic:masterfrom Apr 24, 2020
Merged
Conversation
Contributor
Author
|
I faced the same issue as mentioned here: #62624
and the
So I wonder if app arch team already has a workaround for that? |
sulemanof
added
Feature:NP Migration
release_note:skip
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
69 tasks
Contributor
|
@sulemanof please wait until #62624 will be resolved. This week this issue should be fixed |
# Conflicts: # .github/CODEOWNERS # src/plugins/input_control_vis/public/control/control.test.ts # src/plugins/input_control_vis/public/control/control.ts # src/plugins/input_control_vis/public/control/create_search_source.ts # src/plugins/input_control_vis/public/control/list_control_factory.ts # src/plugins/input_control_vis/public/control/range_control_factory.ts # src/plugins/input_control_vis/public/input_control_fn.test.ts # src/plugins/input_control_vis/public/test_utils/get_search_service_mock.ts # src/plugins/input_control_vis/public/types.ts # src/plugins/input_control_vis/public/vis_controller.tsx
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
flash1293
approved these changes
Apr 24, 2020
Contributor
flash1293
left a comment
flash1293
left a comment
There was a problem hiding this comment.
Tested and input control vis works as expected, LGTM
sulemanof
added a commit
to sulemanof/kibana
that referenced
this pull request
Apr 24, 2020
* Move input_control_vis into NP * Change config paths * Clean up # Conflicts: # .github/CODEOWNERS
sulemanof
added a commit
that referenced
this pull request
Apr 24, 2020
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Apr 27, 2020
…bana into ingest-node-pipeline/open-flyout-create-edit * 'feature/ingest-node-pipelines' of github.com:elastic/kibana: (116 commits) [Ingest Node Pipelines] More lenient treatment of on-failure value (elastic#64411) Report Deletion via UI- functional test (elastic#64031) Bump handlebars dependency from 4.5.3 to 4.7.6 (elastic#64402) [Uptime] Update TLS settings (elastic#64111) [alerting] removes usage of any throughout Alerting Services code (elastic#64161) [CANVAS] Moves notify to a canvas service (elastic#63268) [Canvas] Misc NP Stuff (elastic#63703) update apm index pattern (elastic#64232) Task/hostlist pagination (elastic#63722) [NP] Vega migration (elastic#63849) Move ensureDefaultIndexPattern into data plugin (elastic#63100) [Fleet] Fix agent status count to not include unenrolled agents (elastic#64106) Migrate graph_workspace saved object registration to Kibana platform (elastic#64157) Index pattern management UI -> TypeScript and New Platform Ready (edit_index_pattern) (elastic#64184) [ML] EuiDataGrid ml/transform components. (elastic#63447) [ML] Moving to kibana capabilities (elastic#64057) Move input_control_vis into NP (elastic#63333) remove reference to local application service in graph (elastic#64288) KQL removes leading zero and breaks query (elastic#62748) [FieldFormats] Cleanup: rename IFieldFormatType -> FieldFormatInstanceType (elastic#64193) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moving the
input_control_visplugin into NP.Checklist
Delete any items that are not applicable to this PR.
For maintainers