Added styles to make combobox list items wider for alerting flyout#61894
Merged
YulNaumenko merged 6 commits intoelastic:masterfrom Mar 31, 2020
Merged
Conversation
YulNaumenko
added
Feature:Alerting
v8.0.0
release_note:skip
Contributor
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
cchaos
reviewed
Mar 30, 2020
...ggers_actions_ui/public/application/components/builtin_alert_types/threshold/expression.scss
Outdated
Show resolved
Hide resolved
…box-for-index-hidden # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
cchaos
reviewed
Mar 30, 2020
Contributor
cchaos
left a comment
cchaos
left a comment
There was a problem hiding this comment.
A better implementation just a few suggestions around our SASS conventions.
I'd like to have @andreadelrio do a visual review.
x-pack/plugins/triggers_actions_ui/public/common/expression_items/of.tsx
Outdated
Show resolved
Hide resolved
...ggers_actions_ui/public/application/components/builtin_alert_types/threshold/expression.scss
Outdated
Show resolved
Hide resolved
Contributor
While this fixes the case of having very long names under the |
andreadelrio
requested changes
Mar 30, 2020
Contributor
andreadelrio
left a comment
andreadelrio
left a comment
There was a problem hiding this comment.
Added a comment about visuals. We might need to fix of a more robust solution for dynamic width.
x-pack/plugins/triggers_actions_ui/public/common/expression_items/of.scss
Outdated
Show resolved
Hide resolved
andreadelrio
requested changes
Mar 30, 2020
x-pack/plugins/triggers_actions_ui/public/common/expression_items/of.scss
Outdated
Show resolved
Hide resolved
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
YulNaumenko
added a commit
to YulNaumenko/kibana
that referenced
this pull request
Mar 31, 2020
…lastic#61894) * Added styles to make combobox list items wider for alerting flyout * Fixed width for OF expression popover * Fixed due to comments * Fixed due to comments * Resized
YulNaumenko
added a commit
to YulNaumenko/kibana
that referenced
this pull request
Mar 31, 2020
…lastic#61894) * Added styles to make combobox list items wider for alerting flyout * Fixed width for OF expression popover * Fixed due to comments * Fixed due to comments * Resized
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 31, 2020
* upstream/master: (69 commits) Adding PagerDuty icon to connectors cards (elastic#60805) Fix drag and drop flakiness (elastic#61993) Grok debugger migration (elastic#60658) Endpoint: Fix resolver SVG position issue (elastic#61886) [SIEM] version 7.7 rule import (elastic#61903) Added styles to make combobox list items wider for alerting flyout (elastic#61894) [UA] Tight worker loop can cause high CPU usage (elastic#60950) [ML] DF Analytics results table: use index pattern field format if one exists (elastic#61709) [ML] Catching unknown index pattern errors (elastic#61935) [Discover] Deangularize and euificate sidebar (elastic#47559) Endpoint: Add ts-node dev dependency (elastic#61884) Add an onBlur handler for the kuery bar. Only resubmit when input changes. (elastic#61901) [ML] Handle Empty Partition Field Values in Single Metric Viewer (elastic#61649) Auto interval on date histogram is getting displayed as timestamp per… (elastic#59171) [Maps] Explicitly pass fetch function to ems-client (elastic#61846) [SIEM][CASE] Fix aria-labels and translations (elastic#61670) [ML] Settings: Increase number of items that can be paged in calendars and filters lists (elastic#61842) [EPM] update epm filepath route (elastic#61910) APM] Set ignore_above to 1024 for telemetry saved object (elastic#61732) [Logs UI] Log stream row rendering (elastic#60773) ...
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Apr 1, 2020
* master: (64 commits) Adding PagerDuty icon to connectors cards (elastic#60805) Fix drag and drop flakiness (elastic#61993) Grok debugger migration (elastic#60658) Endpoint: Fix resolver SVG position issue (elastic#61886) [SIEM] version 7.7 rule import (elastic#61903) Added styles to make combobox list items wider for alerting flyout (elastic#61894) [UA] Tight worker loop can cause high CPU usage (elastic#60950) [ML] DF Analytics results table: use index pattern field format if one exists (elastic#61709) [ML] Catching unknown index pattern errors (elastic#61935) [Discover] Deangularize and euificate sidebar (elastic#47559) Endpoint: Add ts-node dev dependency (elastic#61884) Add an onBlur handler for the kuery bar. Only resubmit when input changes. (elastic#61901) [ML] Handle Empty Partition Field Values in Single Metric Viewer (elastic#61649) Auto interval on date histogram is getting displayed as timestamp per… (elastic#59171) [Maps] Explicitly pass fetch function to ems-client (elastic#61846) [SIEM][CASE] Fix aria-labels and translations (elastic#61670) [ML] Settings: Increase number of items that can be paged in calendars and filters lists (elastic#61842) [EPM] update epm filepath route (elastic#61910) APM] Set ignore_above to 1024 for telemetry saved object (elastic#61732) [Logs UI] Log stream row rendering (elastic#60773) ...
mikecote
added
release_note:fix
and removed
release_note:skip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #61020