Skip to content

Comments

Adding PagerDuty icon to connectors cards#60805

Merged
mikecote merged 6 commits intoelastic:masterfrom
mikecote:actions/pd-icon
Mar 31, 2020
Merged

Adding PagerDuty icon to connectors cards#60805
mikecote merged 6 commits intoelastic:masterfrom
mikecote:actions/pd-icon

Conversation

@mikecote
Copy link
Contributor

@mikecote mikecote commented Mar 20, 2020 •
edited
Loading

Resolves #58370

Summary

Re-submission of #60680 but targeting master.

Thanks 🙏 @andreadelrio

image

@mikecote mikecote added Feature:Alerting v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// labels Mar 20, 2020
@mikecote mikecote requested a review from a team as a code owner March 20, 2020 19:46
@mikecote mikecote self-assigned this Mar 20, 2020
@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 20, 2020

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@mikecote mikecote mentioned this pull request Mar 20, 2020
Closed
@mikecote
Copy link
Contributor Author

mikecote commented Mar 20, 2020

This may resolve #58236?

YulNaumenko
YulNaumenko approved these changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexfrancoeur
Copy link

alexfrancoeur commented Mar 25, 2020

@mikecote will this make 7.7? Feels like it's small enough that it could be merged post-FF. We've replaced icons post-FF in the past

@mikecote
Copy link
Contributor Author

mikecote commented Mar 25, 2020

@alexfrancoeur there's a good chance. I ran out of time yesterday but all there's left is to fix the type check failures in CI and we're good to go.

@alexfrancoeur
Copy link

alexfrancoeur commented Mar 25, 2020

👍 thanks Mike!

@mikecote mikecote requested a review from a team as a code owner March 26, 2020 20:55
cqliu1
cqliu1 reviewed Mar 27, 2020
View reviewed changes
Copy link
Contributor

@cqliu1 cqliu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mikecote
Copy link
Contributor Author

mikecote commented Mar 31, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

kibanamachine commented Mar 31, 2020

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

gmmorris
gmmorris approved these changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@gmmorris gmmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mikecote mikecote merged commit 7d97ead into elastic:master Mar 31, 2020
@mikecote mikecote mentioned this pull request Mar 31, 2020
Merged
mikecote added a commit to mikecote/kibana that referenced this pull request Mar 31, 2020
@mikecote @andreadelrio
@spalger @elasticmachine
Adding PagerDuty icon to connectors cards (elastic#60805)
0cceb14 
* adding PagerDuty icon to connectors cards

* Fix jest

* remove unnecessary global typings from canvas and sync global typings in xpack with oss

Co-authored-by: Andrea Del Rio <delrio.andre@gmail.com>
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
mikecote added a commit to mikecote/kibana that referenced this pull request Mar 31, 2020
@mikecote @andreadelrio
@spalger @elasticmachine
Adding PagerDuty icon to connectors cards (elastic#60805)
d3dd109 
* adding PagerDuty icon to connectors cards

* Fix jest

* remove unnecessary global typings from canvas and sync global typings in xpack with oss

Co-authored-by: Andrea Del Rio <delrio.andre@gmail.com>
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@mikecote mikecote mentioned this pull request Mar 31, 2020
Merged
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 31, 2020
@gmmorris
Merge remote-tracking branch 'upstream/master' into alerting/start-trial
2d80df2 
* upstream/master: (69 commits)
  Adding PagerDuty icon to connectors cards (elastic#60805)
  Fix drag and drop flakiness (elastic#61993)
  Grok debugger migration (elastic#60658)
  Endpoint: Fix resolver SVG position issue (elastic#61886)
  [SIEM] version 7.7 rule import (elastic#61903)
  Added styles to make combobox list items wider for alerting flyout (elastic#61894)
  [UA] Tight worker loop can cause high CPU usage (elastic#60950)
  [ML] DF Analytics results table: use index pattern field format if one exists (elastic#61709)
  [ML] Catching unknown index pattern errors (elastic#61935)
  [Discover] Deangularize and euificate sidebar  (elastic#47559)
  Endpoint: Add ts-node dev dependency (elastic#61884)
  Add an onBlur handler for the kuery bar. Only resubmit when input changes. (elastic#61901)
  [ML] Handle Empty Partition Field Values in Single Metric Viewer (elastic#61649)
  Auto interval on date histogram is getting displayed as timestamp per… (elastic#59171)
  [Maps] Explicitly pass fetch function to ems-client (elastic#61846)
  [SIEM][CASE] Fix aria-labels and translations (elastic#61670)
  [ML] Settings: Increase number of items that can be paged in calendars and filters lists (elastic#61842)
  [EPM] update epm filepath route (elastic#61910)
  APM] Set ignore_above to 1024 for telemetry saved object (elastic#61732)
  [Logs UI] Log stream row rendering (elastic#60773)
  ...
pmuellr
pmuellr reviewed Mar 31, 2020
View reviewed changes
Copy link
Contributor

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - since we're changing some typings files used by ALL THE THINGS, should we get someone from operations/platform/something to review this also?

@mikecote
Copy link
Contributor Author

mikecote commented Mar 31, 2020

should we get someone from operations/platform/something to review this also?

We should be all good on that perspective, @spalger from operations team was generous enough to fix the type check issue I was having directly in this PR: fdd6fea and I verified that it worked for us.

mikecote added a commit that referenced this pull request Mar 31, 2020
@mikecote @andreadelrio
@spalger @elasticmachine
Adding PagerDuty icon to connectors cards (#60805) (#62033)
7efdcd5 
* adding PagerDuty icon to connectors cards

* Fix jest

* remove unnecessary global typings from canvas and sync global typings in xpack with oss

Co-authored-by: Andrea Del Rio <delrio.andre@gmail.com>
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Andrea Del Rio <delrio.andre@gmail.com>
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
mikecote added a commit that referenced this pull request Mar 31, 2020
@mikecote @andreadelrio
@spalger @elasticmachine
Adding PagerDuty icon to connectors cards (#60805) (#62034)
27a783e 
* adding PagerDuty icon to connectors cards

* Fix jest

* remove unnecessary global typings from canvas and sync global typings in xpack with oss

Co-authored-by: Andrea Del Rio <delrio.andre@gmail.com>
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Andrea Del Rio <delrio.andre@gmail.com>
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 1, 2020
@gmmorris
Merge branch 'master' into event-log/query-support
a0e1dcd 
* master: (64 commits)
  Adding PagerDuty icon to connectors cards (elastic#60805)
  Fix drag and drop flakiness (elastic#61993)
  Grok debugger migration (elastic#60658)
  Endpoint: Fix resolver SVG position issue (elastic#61886)
  [SIEM] version 7.7 rule import (elastic#61903)
  Added styles to make combobox list items wider for alerting flyout (elastic#61894)
  [UA] Tight worker loop can cause high CPU usage (elastic#60950)
  [ML] DF Analytics results table: use index pattern field format if one exists (elastic#61709)
  [ML] Catching unknown index pattern errors (elastic#61935)
  [Discover] Deangularize and euificate sidebar  (elastic#47559)
  Endpoint: Add ts-node dev dependency (elastic#61884)
  Add an onBlur handler for the kuery bar. Only resubmit when input changes. (elastic#61901)
  [ML] Handle Empty Partition Field Values in Single Metric Viewer (elastic#61649)
  Auto interval on date histogram is getting displayed as timestamp per… (elastic#59171)
  [Maps] Explicitly pass fetch function to ems-client (elastic#61846)
  [SIEM][CASE] Fix aria-labels and translations (elastic#61670)
  [ML] Settings: Increase number of items that can be paged in calendars and filters lists (elastic#61842)
  [EPM] update epm filepath route (elastic#61910)
  APM] Set ignore_above to 1024 for telemetry saved object (elastic#61732)
  [Logs UI] Log stream row rendering (elastic#60773)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pmuellr pmuellr pmuellr left review comments

@cqliu1 cqliu1 cqliu1 left review comments

@YulNaumenko YulNaumenko YulNaumenko approved these changes

+1 more reviewer

@gmmorris gmmorris gmmorris approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mikecote mikecote

Labels

Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v7.7.0 v7.8.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add icon for pagerduty action

10 participants

@mikecote @elasticmachine @alexfrancoeur @kibanamachine @pmuellr @gmmorris @cqliu1 @YulNaumenko @andreadelrio @spalger