Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: 💍 use fake timers in TimedItemBuffer tests #61225

Merged
merged 2 commits into from
Mar 25, 2020
Merged

test: 💍 use fake timers in TimedItemBuffer tests #61225

merged 2 commits into from
Mar 25, 2020

Conversation

streamich
Copy link
Contributor

✅ Closes: #58662

@streamich streamich requested a review from a team as a code owner March 25, 2020 09:23
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

lizozom
lizozom approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@lizozom lizozom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@streamich
Copy link
Contributor Author

retest

@streamich
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@streamich streamich merged commit 2255256 into elastic:master Mar 25, 2020
This was referenced Mar 25, 2020
Merged
Merged
streamich added a commit that referenced this pull request Mar 26, 2020
@streamich @elasticmachine
test: 💍 use fake timers in TimedItemBuffer tests (#61225) (#61370)
9e17e82 
✅ Closes: #58662

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
streamich added a commit that referenced this pull request Mar 26, 2020
@streamich
test: 💍 use fake timers in TimedItemBuffer tests (#61225) (#61369)
640deca 
✅ Closes: #58662
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizozom lizozom lizozom approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes review test-failure-flaky v7.7.0 v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
4 participants
@streamich @elasticmachine @kibanamachine @lizozom