Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Jest Tests.src/plugins/bfetch/common/buffer/tests - TimedItemBuffer does not automatically flush if .clear() was called #58662

Closed
kibanamachine opened this issue Feb 26, 2020 · 6 comments · Fixed by #61225
Closed

Failing test: Jest Tests.src/plugins/bfetch/common/buffer/tests - TimedItemBuffer does not automatically flush if .clear() was called #58662

kibanamachine opened this issue Feb 26, 2020 · 6 comments · Fixed by #61225
Assignees
@streamich
Labels
blocker failed-test A test failure on a tracked branch, potentially flaky-test skipped-test

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Feb 26, 2020 •
edited
Loading

A test failed on a tracked branch

Error: expect(jest.fn()).toHaveBeenCalledTimes(expected)

Expected number of calls: 0
Received number of calls: 1
    at Object.test (/var/lib/jenkins/workspace/elastic+kibana+7.x/kibana/src/plugins/bfetch/common/buffer/tests/timed_item_buffer.test.ts:100:21)

First failure: Jenkins Build
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Feb 26, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-test-triage (failed-test)

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@spalger
Copy link
Contributor

spalger commented Feb 28, 2020 •
edited
Loading

Unlike what I would normally expect this doesn't seem to have failed in a PR in the last 30 days, either way we should fix this.

image

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

spalger added a commit that referenced this issue Feb 28, 2020
@spalger
skip flaky suite (#58662)
8a8af5a
spalger added a commit that referenced this issue Feb 28, 2020
@spalger
skip flaky suite (#58662)
37c656a 
(cherry picked from commit 8a8af5a)
@spalger
Copy link
Contributor

spalger commented Feb 28, 2020

Skipped

master: 8a8af5a
7.x/7.7: 37c656a

@streamich streamich mentioned this issue Mar 25, 2020
Merged
streamich added a commit that referenced this issue Mar 25, 2020
@streamich @elasticmachine
test: 💍 use fake timers in TimedItemBuffer tests (#61225)
2255256 
✅ Closes: #58662

Co-authored-by: Elastic Machine <[email protected]>
streamich added a commit that referenced this issue Mar 26, 2020
@streamich @elasticmachine
test: 💍 use fake timers in TimedItemBuffer tests (#61225) (#61370)
9e17e82 
✅ Closes: #58662

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
streamich added a commit that referenced this issue Mar 26, 2020
@streamich
test: 💍 use fake timers in TimedItemBuffer tests (#61225) (#61369)
640deca 
✅ Closes: #58662
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@streamich streamich

Labels
blocker failed-test A test failure on a tracked branch, potentially flaky-test skipped-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: 💍 use fake timers in TimedItemBuffer tests
4 participants
@spalger @streamich @elasticmachine @kibanamachine