Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embeddable cleanup: remove unused, non-serializable, input params #61102

Merged
merged 4 commits into from
Mar 25, 2020
Merged

Embeddable cleanup: remove unused, non-serializable, input params #61102

merged 4 commits into from
Mar 25, 2020

Conversation

stacey-gammon
Copy link
Contributor

Ideally this would be typescript checked but I looked into that briefly and it's a big effort because Filters type actually isn't serializable. We should fix that too at some point.

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@stacey-gammon stacey-gammon marked this pull request as ready for review March 24, 2020 18:20
@stacey-gammon stacey-gammon requested a review from a team as a code owner March 24, 2020 18:20
@stacey-gammon stacey-gammon added v7.8 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Mar 24, 2020
ppisljar
ppisljar approved these changes Mar 25, 2020
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stacey-gammon stacey-gammon merged commit 6d924c5 into elastic:master Mar 25, 2020
@stacey-gammon stacey-gammon mentioned this pull request Mar 25, 2020
Merged
stacey-gammon added a commit to stacey-gammon/kibana that referenced this pull request Mar 25, 2020
@stacey-gammon
Embeddable cleanup: remove unused, non-serializable, input params (el…
dd76062 
…astic#61102)

* remove unused, non-serializable, input params

* Fix merge mistakes
stacey-gammon added a commit that referenced this pull request Mar 25, 2020
@stacey-gammon
Embeddable cleanup: remove unused, non-serializable, input params (#6…
53a3c18 
…1102) (#61293)

* remove unused, non-serializable, input params

* Fix merge mistakes
@rayafratkina rayafratkina added v7.8.0 and removed v7.8 labels Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppisljar ppisljar ppisljar approved these changes

Assignees
No one assigned
Labels
chore Feature:Embedding Embedding content via iFrame release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stacey-gammon @elasticmachine @kibanamachine @ppisljar @rayafratkina