Skip to content

Commit

Permalink
Embeddable cleanup: remove unused, non-serializable, input params (#6…
Browse files Browse the repository at this point in the history
…1102)

* remove unused, non-serializable, input params

* Fix merge mistakes
  • Loading branch information
stacey-gammon authored Mar 25, 2020
1 parent 7c18d70 commit 6d924c5
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ import {
IExpressionLoaderParams,
ExpressionsStart,
} from '../../../../../../../plugins/expressions/public';
import { PersistedState } from '../../../../../../../plugins/visualizations/public';
import { buildPipeline } from '../legacy/build_pipeline';
import { Vis } from '../vis';
import { getExpressions, getUiActions } from '../services';
Expand All @@ -54,8 +53,6 @@ export interface VisualizeEmbeddableConfiguration {
indexPatterns?: IIndexPattern[];
editUrl: string;
editable: boolean;
appState?: { save(): void };
uiState?: PersistedState;
}

export interface VisualizeInput extends EmbeddableInput {
Expand All @@ -65,8 +62,6 @@ export interface VisualizeInput extends EmbeddableInput {
vis?: {
colors?: { [key: string]: string };
};
appState?: { save(): void };
uiState?: PersistedState;
}

export interface VisualizeOutput extends EmbeddableOutput {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,6 @@ export class VisualizeEmbeddableFactory extends EmbeddableFactory<
indexPatterns,
editUrl,
editable,
appState: input.appState,
uiState: input.uiState,
},
input,
parent
Expand Down

0 comments on commit 6d924c5

Please sign in to comment.