Skip to content

[Alerting] removes boom errors from AlertNavigationRegistry#60887

Merged
gmmorris merged 1 commit intoelastic:masterfrom
gmmorris:alerting/remove-boom
Mar 23, 2020
Merged

[Alerting] removes boom errors from AlertNavigationRegistry#60887
gmmorris merged 1 commit intoelastic:masterfrom
gmmorris:alerting/remove-boom

Conversation

@gmmorris
Copy link
Contributor

@gmmorris gmmorris commented Mar 23, 2020

Summary

closes #60860

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@gmmorris gmmorris added Feature:Alerting v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// labels Mar 23, 2020
@gmmorris gmmorris requested a review from a team as a code owner March 23, 2020 08:57
@gmmorris gmmorris changed the title [alerting] removes boom errors from AlertNavigationRegistry [Alerting] removes boom errors from AlertNavigationRegistry Mar 23, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; curious why Boom was used at all here, or if there is some specific reason Boom usage is being removed - nvm looked at the referenced issue :-)

Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmmorris gmmorris merged commit 7dc45f5 into elastic:master Mar 23, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 23, 2020
@gmmorris gmmorris deleted the alerting/remove-boom branch March 23, 2020 13:14
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 23, 2020
* master:
  [Remote clustersadopt changes to remote info API (elastic#60795)
  Only run xpack siem cypress in PRs when there are siem changes (elastic#60661)
  [CI] Add error steps and help links to PR comments (elastic#60772)
  skip flaky functional test (elastic#60898)
  [Alerting] Fixes mistake in empty list assertion (elastic#60896)
  a11y tests for login and logout (elastic#60799)
  removed boom errors from AlertNavigationRegistry (elastic#60887)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backported Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v7.7.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Alerting] Remove Boom usage from Alert Navigation Registry

4 participants