[CI] Add error steps and help links to PR comments#60772
Merged
brianseeders merged 8 commits intoelastic:masterfrom Mar 23, 2020
Merged
[CI] Add error steps and help links to PR comments#60772brianseeders merged 8 commits intoelastic:masterfrom
brianseeders merged 8 commits intoelastic:masterfrom
Conversation
Contributor
Author
|
Example for posterity 💔 Build Failed
Failed CI Steps
History
To update your PR or re-run it, just comment with: |
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
brianseeders
commented
Mar 20, 2020
| @@ -0,0 +1,21 @@ | |||
| def getSteps() { | |||
| def url = "${env.BUILD_URL}api/json?tree=actions[nodes[iconColor,running,displayName,id,parents]]" | |||
Contributor
Author
There was a problem hiding this comment.
Creating URLs with proper tools looks like this:
def builder = new URIBuilder(env.BUILD_URL)
def url = builder
.setPathSegments(builder.getPathSegments() + ['api', 'json'])
.setParameter('tree', 'actions[nodes[iconColor,running,displayName,id,parents]]')
.toString()and actually produces incorrectly-formatted URLs, e.g.
https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/34782//api/json?tree=actions%5Bnodes%5BiconColor%2Crunning%2CdisplayName%2Cid%2Cparents%5D%5D
(notice the double //)
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/uptime/settings·ts.Uptime app with generated data uptime settings page changing index pattern setting is reflected elsewhere in UIStandard OutStack TraceHistory
To update your PR or re-run it, just comment with: |
brianseeders
added a commit
to brianseeders/kibana
that referenced
this pull request
Mar 23, 2020
This was referenced Mar 23, 2020
brianseeders
added a commit
to brianseeders/kibana
that referenced
this pull request
Mar 23, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 23, 2020
* master: [Remote clustersadopt changes to remote info API (elastic#60795) Only run xpack siem cypress in PRs when there are siem changes (elastic#60661) [CI] Add error steps and help links to PR comments (elastic#60772) skip flaky functional test (elastic#60898) [Alerting] Fixes mistake in empty list assertion (elastic#60896) a11y tests for login and logout (elastic#60799) removed boom errors from AlertNavigationRegistry (elastic#60887)
brianseeders
added a commit
that referenced
this pull request
Mar 23, 2020
brianseeders
added a commit
that referenced
this pull request
Mar 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add links to CI help page and directly to failed pipeline steps to PR comments.
I considered limiting the number of failed steps that will show up in the comment, but am currently choosing to let them all through and change it later if it ends up being an issue.
I'm filtering out git checkout errors, since those happen on so many jobs and aren't useful.
See below for example.