Skip to content

[junit] only include stdout in report for failures #60530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spalger merged 2 commits into from
Mar 19, 2020
Merged

[junit] only include stdout in report for failures #60530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
753824a
[junit] only include stdout in report for failures
spalger Mar 18, 2020
810ef83
fix assertion
spalger Mar 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/kbn-test/src/mocha/__tests__/junit_report_generation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ describe('dev/mocha/junit report generation', () => {
name: 'SUITE SUB_SUITE never runs',
'metadata-json': '{}',
},
'system-out': testFail['system-out'],
'system-out': ['-- logs are only reported for failed tests --'],
skipped: [''],
});
});
Expand Down
4 changes: 3 additions & 1 deletion packages/kbn-test/src/mocha/junit_report_generation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,13 +126,15 @@ export function setupJUnitReportGeneration(runner, options = {}) {

[...results, ...skippedResults].forEach(result => {
const el = addTestcaseEl(result.node);
el.ele('system-out').dat(escapeCdata(getSnapshotOfRunnableLogs(result.node) || ''));

if (result.failed) {
el.ele('system-out').dat(escapeCdata(getSnapshotOfRunnableLogs(result.node) || ''));
el.ele('failure').dat(escapeCdata(inspect(result.error)));
return;
}

el.ele('system-out').dat('-- logs are only reported for failed tests --');

if (result.skipped) {
el.ele('skipped');
}
Expand Down