Async search cancellation UI by lizozom · Pull Request #60058 · elastic/kibana

lizozom · 2020-03-12T18:59:45Z

Summary

Based of #59714
Resolves #24227.
Resolves #46370.
Waiting on #53538.

This PR adds the functionality needed to batch cancel in-progress queries as well as allow queries to run beyond the configured timeouts (both elasticsearch.shardTimeout and elasticsearch.requestTimeout).

It also adds the UI as demoed in the mockups

What still needs to be done -

Make run beyond timeout disabled in OSS
- Move runBeyondTimeout to data_enhanced
- Make a registry for async query actions
Remove the async search actions from the plugin API (use setSearchInterceptor instead)
Re-build the UI component
Implement info level notifications + support two buttons
Canceled embeddable indication
Support feature controls

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility, including a check against IE11

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2020-03-12T18:59:48Z

Pinging @elastic/kibana-app-arch (Team:AppArch)

…i-search-cancel

…latform/ui-search-cancel

kibanamachine · 2020-03-16T19:24:07Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: f496d16

Test Failures

Kibana Pipeline / kibana-xpack-agent / "after all" hook for "Loads prebuilt rules".Signal detection rules "after all" hook for "Loads prebuilt rules"

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

Error: Minified React error #301; visit https://reactjs.org/docs/error-decoder.html?invariant=301 for the full message or use the non-minified dev environment for full errors and additional helpful warnings.

Because this error occurred during a 'before all' hook we are skipping the remaining tests in the current suite: 'Signal detection rules'

Because this error occurred during a 'after all' hook we are skipping the remaining tests in the current suite: 'Signal detection rules'
    at Oa (http://localhost:61121/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:400:62306)
    at SafeSubscriber._next (http://localhost:61121/bundles/commons.bundle.js:3:4305287)
    at SafeSubscriber.__tryOrUnsub (http://localhost:61121/bundles/plugin/data/data.plugin.js:15:116240)
    at SafeSubscriber.next (http://localhost:61121/bundles/plugin/data/data.plugin.js:15:114680)
    at Subscriber._next (http://localhost:61121/bundles/plugin/data/data.plugin.js:15:113069)
    at Subscriber.next (http://localhost:61121/bundles/plugin/data/data.plugin.js:15:112666)
    at BehaviorSubject._subscribe (http://localhost:61121/bundles/plugin/data/data.plugin.js:27:200965)
    at BehaviorSubject.Observable._trySubscribe (http://localhost:61121/bundles/plugin/data/data.plugin.js:15:121365)
    at BehaviorSubject.Subject._trySubscribe (http://localhost:61121/bundles/plugin/data/data.plugin.js:15:163189)
    at BehaviorSubject.Observable.subscribe (http://localhost:61121/bundles/plugin/data/data.plugin.js:15:121100)

Kibana Pipeline / kibana-xpack-agent / "after all" hook for "launches the inspect query modal when the inspect button is clicked".Events Viewer Events viewer query modal "after all" hook for "launches the inspect query modal when the inspect button is clicked"

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

Error: Minified React error #301; visit https://reactjs.org/docs/error-decoder.html?invariant=301 for the full message or use the non-minified dev environment for full errors and additional helpful warnings.

Because this error occurred during a 'before all' hook we are skipping the remaining tests in the current suite: 'Events viewer query modal'

Because this error occurred during a 'after all' hook we are skipping the remaining tests in the current suite: 'Events viewer query modal'
    at Oa (http://localhost:61121/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:400:62306)
    at SafeSubscriber._next (http://localhost:61121/bundles/plugin/data/data.plugin.js:81:457589)
    at SafeSubscriber.__tryOrUnsub (http://localhost:61121/bundles/plugin/data/data.plugin.js:15:116240)
    at SafeSubscriber.next (http://localhost:61121/bundles/plugin/data/data.plugin.js:15:114680)
    at Subscriber._next (http://localhost:61121/bundles/plugin/data/data.plugin.js:15:113069)
    at Subscriber.next (http://localhost:61121/bundles/plugin/data/data.plugin.js:15:112666)
    at BehaviorSubject._subscribe (http://localhost:61121/bundles/plugin/data/data.plugin.js:27:200965)
    at BehaviorSubject.Observable._trySubscribe (http://localhost:61121/bundles/plugin/data/data.plugin.js:15:121365)
    at BehaviorSubject.Subject._trySubscribe (http://localhost:61121/bundles/plugin/data/data.plugin.js:15:163189)
    at BehaviorSubject.Observable.subscribe (http://localhost:61121/bundles/plugin/data/data.plugin.js:15:121100)

Kibana Pipeline / kibana-xpack-agent / "after each" hook for "inspects the Hosts Stat".Inspect Hosts stats and tables "after each" hook for "inspects the Hosts Stat"

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

Error: Minified React error #301; visit https://reactjs.org/docs/error-decoder.html?invariant=301 for the full message or use the non-minified dev environment for full errors and additional helpful warnings.

Because this error occurred during a 'after each' hook we are skipping the remaining tests in the current suite: 'Hosts stats and tables'
    at Oa (http://localhost:61121/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:400:62306)
    at SafeSubscriber._next (http://localhost:61121/bundles/plugin/data/data.plugin.js:81:457589)
    at SafeSubscriber.__tryOrUnsub (http://localhost:61121/bundles/plugin/data/data.plugin.js:15:116240)
    at SafeSubscriber.next (http://localhost:61121/bundles/plugin/data/data.plugin.js:15:114680)
    at Subscriber._next (http://localhost:61121/bundles/plugin/data/data.plugin.js:15:113069)
    at Subscriber.next (http://localhost:61121/bundles/plugin/data/data.plugin.js:15:112666)
    at BehaviorSubject._subscribe (http://localhost:61121/bundles/plugin/data/data.plugin.js:27:200965)
    at BehaviorSubject.Observable._trySubscribe (http://localhost:61121/bundles/plugin/data/data.plugin.js:15:121365)
    at BehaviorSubject.Subject._trySubscribe (http://localhost:61121/bundles/plugin/data/data.plugin.js:15:163189)
    at BehaviorSubject.Observable.subscribe (http://localhost:61121/bundles/plugin/data/data.plugin.js:15:121100)

and 48 more failures, only showing the first 3.

History

💔 Build #33527 failed 19c1284
💔 Build #33427 failed b3ee069
💔 Build #32894 failed b9fd156

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

lukasolson · 2020-03-16T21:54:31Z

src/plugins/data/public/ui/query_string_input/loading_button.tsx

+        onClick={() => {
+          setIsOpen(!isOpen);
+        }}
+        // isLoading={true}


Nit: Remove this comment.

Also, is there currently no way to show multiple icons in an EuiButton? (One for the loading indicator, and the other one you already have here.)

lukasolson · 2020-03-16T21:55:57Z

src/plugins/data/public/ui/query_string_input/query_bar_top_row.tsx

+        data.search.cancelPendingSearches();
+        break;
+      case LoadingButtonAction.ActionRunBeyondTimeout:
+        // TODO: implement me


This can be implemented now.

src/plugins/data/public/ui/search_bar/search_bar.tsx

mdefazio · 2020-03-17T02:17:12Z

This looks good. Did we still want to promote one of the options behind the loading button? Changing the first option to be a primary filled button?

I wasn't able to get the toast to show (I think issues on my end), perhaps we can zoom tomorrow?

lizozom · 2020-03-18T18:39:04Z

closing due to UI changes

lukasolson and others added 30 commits December 9, 2019 11:16

Add async search strategy

02c57f3

Add async search

41b7c6a

Fix async strategy and add tests

cf5ceb9

Merge branch 'master' into asyncSearch

5ad5b36

Move types to separate file

2009343

Revert changes to demo search

ebebdaf

Merge branch 'master' into asyncSearch

65c39b6

Update demo search strategy to use async

5dd876f

Add async es search strategy

d487812

Return response as rawResponse

7433aa6

Poll after initial request

93ea93e

Merge branch 'master' into asyncSearch

8e8eb7b

Merge branch 'master' into enhancedEsSearch

f15c4af

Merge branch 'master' into asyncSearch

50b4b69

Merge branch 'master' into asyncSearch

2bed4a6

Merge branch 'asyncSearch' into enhancedEsSearch

b6d9c25

Add cancellation to search strategies

7260761

Add tests

be300db

Merge branch 'master' into asyncSearch

fa02de6

Merge branch 'asyncSearch' into enhancedEsSearch

4e524d1

Merge branch 'master' into asyncSearch

7ad5755

Simplify async search strategy

e4eb651

Merge branch 'asyncSearch' into enhancedEsSearch

b6a7f5e

Move loadingCount to search strategy

6188c74

Merge branch 'loadingCount' into asyncSearch

765ec61

Merge branch 'asyncSearch' into enhancedEsSearch

b35ca0f

Update abort controller library

f15f138

Bootstrap

4d36124

Merge branch 'master' into abortController

1943855

Merge branch 'master' into asyncSearch

c7e328c

lukasolson and others added 3 commits March 12, 2020 11:26

Review feedback

df058c2

Merge branch 'enhancedEsSearch' into searchInterceptor

d191ee4

UI to stop async searches

b9fd156

lizozom added Feature:New Platform v8.0.0 Team:AppArch release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Mar 12, 2020

lizozom requested a review from lukasolson March 12, 2020 18:59

lizozom requested a review from a team as a code owner March 12, 2020 18:59

lizozom self-assigned this Mar 12, 2020

lukasolson and others added 6 commits March 12, 2020 12:34

Add service for running beyond timeout

e095cd5

Refactor abort utils

f4dbd29

Remove unneeded changes

e61cbe5

Add tests

1b54481

Merge branch 'master' of github.com:elastic/kibana into newplatform/u…

b3ee069

…i-search-cancel

Merge remote-tracking branch 'lukasolson/searchInterceptor' into newp…

19c1284

…latform/ui-search-cancel

lizozom requested a review from a team March 16, 2020 17:50

lizozom mentioned this pull request Mar 16, 2020

[skip-ci] UI for cancelling queries & running beyond timeout #59714

Closed

7 tasks

lizozom requested a review from mdefazio March 16, 2020 17:53

docs

f496d16

lukasolson reviewed Mar 16, 2020

View reviewed changes

src/plugins/data/public/ui/search_bar/search_bar.tsx Show resolved Hide resolved

lukasolson mentioned this pull request Mar 17, 2020

[Search] Refactor service to register search strategies, not providers #60342

Merged

7 tasks

lizozom closed this Mar 18, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Async search cancellation UI#60058

Async search cancellation UI#60058
lizozom wants to merge 140 commits intoelastic:masterfrom
lizozom:newplatform/ui-search-cancel

lizozom commented Mar 12, 2020 •

edited

Loading

Uh oh!

elasticmachine commented Mar 12, 2020

Uh oh!

kibanamachine commented Mar 16, 2020

Standard Out

Stack Trace

Standard Out

Stack Trace

Standard Out

Stack Trace

Uh oh!

lukasolson Mar 16, 2020

Uh oh!

lukasolson Mar 16, 2020

Uh oh!

Uh oh!

mdefazio commented Mar 17, 2020

Uh oh!

lizozom commented Mar 18, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments

Conversation

lizozom commented Mar 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Mar 12, 2020

Uh oh!

kibanamachine commented Mar 16, 2020

💔 Build Failed

Test Failures

Standard Out

Stack Trace

Standard Out

Stack Trace

Standard Out

Stack Trace

History

Uh oh!

lukasolson Mar 16, 2020

Choose a reason for hiding this comment

Uh oh!

lukasolson Mar 16, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mdefazio commented Mar 17, 2020

Uh oh!

lizozom commented Mar 18, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

lizozom commented Mar 12, 2020 •

edited

Loading