[Maps] Fix custom color ramp on save

[nreese]

Refactoring for categorical color palettes introduced a bug with ordinal custom color ramps. To view the bug, follow the following steps

1. Create map with single document layer from web logs.
2. Style fill color by value on the field bytes. Add at least 2 color stops
3. Save the map by clicking save in the top nav. Notice that the map fill color is not longer styled after saving.

Before saving

After saving

The problem is this guard against incomplete color configuration, https://github.com/elastic/kibana/blob/7.6/x-pack/legacy/plugins/maps/public/layers/styles/vector/properties/dynamic_color_property.js#L108

const isDynamicConfigComplete =
      _.has(this._options, 'field.name') && _.has(this._options, 'color');
    if (!isDynamicConfigComplete) {
      return null;
    }

During the refactoring for categorical color palettes, styleOptions.color is getting removed from the options during save. This causes this guard to return false even though the color configuration is complete for custom color ramp.

This PR cleans up the logic of _getMbColor to better check for config completeness when using custom color ramps and palettes. The PR also adds some unit tests to ensure the various configurations work as expected.

[elasticmachine]

Pinging @elastic/kibana-gis (Team:Geo)

[thomasneirynck]

thanks for fixing.

fwiw I wouldn't do this method rename in a spot-fix for a patch like this.

[thomasneirynck]

thanks for removing and improving symmetry between cat and ordinal

[nreese]

@elasticmachine merge upstream

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 45a1292

History

• 💔 Build #32587 failed 0e7eb22
• 💚 Build #32580 succeeded df89c07

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream