[SIEM] Adds 'Load prebuilt rules' Cypress test#59529
Merged
MadameSheema merged 3 commits intoelastic:masterfrom Mar 6, 2020
Merged
[SIEM] Adds 'Load prebuilt rules' Cypress test#59529MadameSheema merged 3 commits intoelastic:masterfrom
MadameSheema merged 3 commits intoelastic:masterfrom
Conversation
MadameSheema
added
Team:SIEM
v8.0.0
release_note:skip
MadameSheema
requested review from
FrankHassanabad,
dhurley14,
patrykkopycinski,
rylnd,
spong and
yctercero
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
yctercero
reviewed
Mar 6, 2020
Contributor
yctercero
left a comment
yctercero
left a comment
There was a problem hiding this comment.
Thanks for adding this! Would this also be a good place to test the filter/search in All rules page?
Contributor
Author
|
@yctercero if we cannot cover that behaviour with jest, we can add a new test in Cypress :) |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
FrankHassanabad
approved these changes
Mar 6, 2020
Contributor
FrankHassanabad
left a comment
FrankHassanabad
left a comment
There was a problem hiding this comment.
Thanks for adding the first set! LGTM
MadameSheema
added a commit
to MadameSheema/kibana
that referenced
this pull request
Mar 6, 2020
* adds 'load prebuilt rules' * fixes typecheck issue * updates jest snapshot
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
kibanamachine
added
the
backport missing
MadameSheema
added a commit
to MadameSheema/kibana
that referenced
this pull request
Mar 8, 2020
* adds 'load prebuilt rules' * fixes typecheck issue * updates jest snapshot
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 9, 2020
* master: (154 commits) Add an optional authentication mode for HTTP resources (elastic#58589) Implement embeddable drilldown menu options (elastic#59232) [Alerting] "Create alert" graph visualization design improvements (elastic#59399) Alerting update route throttle property is missing (elastic#59580) [SIEM] Adds 'Load prebuilt rules' Cypress test (elastic#59529) Show error if field is not found during filter rendering (elastic#59298) Navigate back to discover app during test, because the saved search from the preceding test has major performance problems when used with this test (elastic#59571) Check for alert dialog when doing a force logout (elastic#59329) ensure fs deletes are not cwd dependent (elastic#59570) Empty message for APM service map (elastic#59518) [Drilldowns] <ActionWizard/> Component (elastic#59032) [Reporting] Improve the page exit error messages (elastic#59351) Ensure logged out starting state for tests that need it (elastic#59322) Hide input value from kbn-config-schema error messages (elastic#58843) [ML] Transforms: Migrate client plugin to NP. (elastic#59443) [ML] Disable failing functional tests [SIEM] Update Timeline to use the latest euiFlyoutBody style (elastic#59524) Temporarily remove the project mappings for PR labels (elastic#59493) [Alerting] replace index threshold graph usage of watcher APIs with new API (elastic#59385) [ML] Show view series link in anomalies table for machine_learning_user role (elastic#59549) ...
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
MadameSheema
added a commit
that referenced
this pull request
Mar 10, 2020
* [SIEM] Adds 'Load prebuilt rules' Cypress test (#59529) * adds 'load prebuilt rules' * fixes typecheck issue * updates jest snapshot * [SIEM] Adds 'Load prebuilt rules' Cypress test (#59529) * adds 'load prebuilt rules' * fixes typecheck issue * updates jest snapshot Co-authored-by: patrykkopycinski <patryk.kopycinski@elastic.co>
kibanamachine
removed
the
backport missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In this PR we are adding a Cypress test in order to check that the prebuilt Elastic rules are correctly loaded.
In order to do that the test is performing the following actions:
Note that this test has been written thinking that is going to be executed using the CI mode using the data prepared for the test using es_archiver, if you want to execute it in a different environment, the rules should not be previously loaded.