[Alerting] replace index threshold graph usage of watcher APIs with new API#59385
Merged
pmuellr merged 6 commits intoelastic:masterfrom Mar 6, 2020
Merged
Conversation
pmuellr
added
Feature:Alerting
Team:ResponseOps
Contributor
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
pmuellr
added
v7.7.0
release_note:skip
pmuellr
force-pushed
the
alerting/index-threshold-graph
branch
from
4ab53f6 to
dc70d72
Compare
pmuellr
force-pushed
the
alerting/index-threshold-graph
branch
from
dc70d72 to
9e3843a
Compare
pmuellr
changed the title
Contributor
Author
|
If you want to see the graph in action, you can use this simulator which can generate interesting data for the graph, changing every second: https://github.com/pmuellr/es-apm-sys-sim |
mikecote
approved these changes
Mar 5, 2020
Contributor
mikecote
left a comment
mikecote
left a comment
There was a problem hiding this comment.
Code LGTM 👍 just one comment but awesome to see time buckets are gone!!
| "server": false, | ||
| "ui": true, | ||
| "requiredPlugins": ["management", "charts", "data"] | ||
| "requiredPlugins": ["management", "charts", "data", "alerting", "alertingBuiltins"] |
Contributor
There was a problem hiding this comment.
I'm wondering if these should be optional dependencies? This would allow the scenario the alerting plugin is disabled but actions / connectors plugin is enabled. (UI would still show)
Contributor
Author
There was a problem hiding this comment.
Ya, that makes sense. I think for both of these, I ended up moving some code to common, that this plugin imported, so wanted to note the dependency, somehow. Of course, it doesn't matter if those deps aren't enabled :-). Optional makes more sense.
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
pmuellr
added a commit
to pmuellr/kibana
that referenced
this pull request
Mar 6, 2020
…ew API (elastic#59385) Changes the alerting UI to use the new time series query HTTP endpoint provided by the builtin index threshold alertType; previously it used a watcher HTTP endpoint. This is part of the ongoing index threshold work tracked in elastic#53041
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 9, 2020
* master: (154 commits) Add an optional authentication mode for HTTP resources (elastic#58589) Implement embeddable drilldown menu options (elastic#59232) [Alerting] "Create alert" graph visualization design improvements (elastic#59399) Alerting update route throttle property is missing (elastic#59580) [SIEM] Adds 'Load prebuilt rules' Cypress test (elastic#59529) Show error if field is not found during filter rendering (elastic#59298) Navigate back to discover app during test, because the saved search from the preceding test has major performance problems when used with this test (elastic#59571) Check for alert dialog when doing a force logout (elastic#59329) ensure fs deletes are not cwd dependent (elastic#59570) Empty message for APM service map (elastic#59518) [Drilldowns] <ActionWizard/> Component (elastic#59032) [Reporting] Improve the page exit error messages (elastic#59351) Ensure logged out starting state for tests that need it (elastic#59322) Hide input value from kbn-config-schema error messages (elastic#58843) [ML] Transforms: Migrate client plugin to NP. (elastic#59443) [ML] Disable failing functional tests [SIEM] Update Timeline to use the latest euiFlyoutBody style (elastic#59524) Temporarily remove the project mappings for PR labels (elastic#59493) [Alerting] replace index threshold graph usage of watcher APIs with new API (elastic#59385) [ML] Show view series link in anomalies table for machine_learning_user role (elastic#59549) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of the removal of the watcher APIs used in the alerting ui plugin. Replaced with a new API provided by the built-in index threshold alertType.
Note that I moved some portable code in the
alertingandalerting_builtinsplugins fromservertocommon, to reuse in the UI.And time_buckets are gone :-)
I had to thread the alert interval into the form, wasn't currently being used, but we end up needing it to generate the graph data with the new APIs.