Stabilize dashboard snapshot toast closing #58709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash1293
added
v7.6.2
v7.7.0
v8.0.0
Feature:Functional Testing
release_note:skip
Contributor
Author
|
Jenkins, test this. |
flash1293
added
the
Team:Visualizations
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
liza-mae
approved these changes
Mar 2, 2020
Contributor
liza-mae
left a comment
liza-mae
left a comment
There was a problem hiding this comment.
LGTM, I ran it 25 times and did not see any failures. Thanks @flash1293 !
mbondyra
approved these changes
Mar 3, 2020
Contributor
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Member
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Mar 4, 2020
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Mar 4, 2020
flash1293
added a commit
that referenced
this pull request
Mar 4, 2020
flash1293
added a commit
that referenced
this pull request
Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58707
The dashboard snapshot tests add a visualization and try to close the success toast afterwards. If the timing is bad, the toast can auto-close before the tries gets to closing it which will result in an error because the
closeToastfunction fails if there is no toast to close.This PR adds a new function
closeToastIfExistswhich will not fail in this scenario and uses it for the dashboard snapshot tests