Skip to content

Commit 46dcea5

Browse files
authored
stabilize dashboard snapshot toast closing (#58709) (#59271)
1 parent fda06ee commit 46dcea5

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

test/functional/apps/dashboard/dashboard_snapshots.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ export default function({ getService, getPageObjects, updateBaselines }) {
5050
await PageObjects.dashboard.clickNewDashboard();
5151
await PageObjects.timePicker.setLogstashDataRange();
5252
await dashboardAddPanel.addVisualization('Rendering Test: tsvb-ts');
53-
await PageObjects.common.closeToast();
53+
await PageObjects.common.closeToastIfExists();
5454

5555
await PageObjects.dashboard.saveDashboard('tsvb');
5656
await PageObjects.dashboard.clickFullScreenMode();
@@ -73,7 +73,7 @@ export default function({ getService, getPageObjects, updateBaselines }) {
7373
await PageObjects.dashboard.clickNewDashboard();
7474
await PageObjects.timePicker.setLogstashDataRange();
7575
await dashboardAddPanel.addVisualization('Rendering Test: area with not filter');
76-
await PageObjects.common.closeToast();
76+
await PageObjects.common.closeToastIfExists();
7777

7878
await PageObjects.dashboard.saveDashboard('area');
7979
await PageObjects.dashboard.clickFullScreenMode();

test/functional/page_objects/common_page.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -429,6 +429,13 @@ export function CommonPageProvider({ getService, getPageObjects }: FtrProviderCo
429429
return title;
430430
}
431431

432+
async closeToastIfExists() {
433+
const toastShown = await find.existsByCssSelector('.euiToast');
434+
if (toastShown) {
435+
await this.closeToast();
436+
}
437+
}
438+
432439
async clearAllToasts() {
433440
const toasts = await find.allByCssSelector('.euiToast');
434441
for (const toastElement of toasts) {

0 commit comments

Comments
 (0)