Skip to content

Comments

[File upload] Update remaining File Upload dependencies for NP migration#58128

Merged
kindsun merged 7 commits intoelastic:masterfrom
kindsun:np-update-remaining-file-upload-dependencies
Feb 21, 2020
Merged

[File upload] Update remaining File Upload dependencies for NP migration#58128
kindsun merged 7 commits intoelastic:masterfrom
kindsun:np-update-remaining-file-upload-dependencies

Conversation

@kindsun
Copy link
Contributor

@kindsun kindsun commented Feb 20, 2020

Summary

Replace existing legacy services with their NP equivalents

  • elasticsearch -> elasticsearch (NP)
  • getSavedObjectsRepository -> getInternalRepository
    General cleanup
    Tests update

@kindsun kindsun added Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:File Upload Feature:NP Migration v7.7.0 labels Feb 20, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@kindsun kindsun marked this pull request as ready for review February 20, 2020 16:28
@kindsun kindsun requested review from joshdover and nreese February 20, 2020 16:28
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
code review

@kindsun
Copy link
Contributor Author

kindsun commented Feb 21, 2020

retest

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kindsun kindsun merged commit 9c8c47b into elastic:master Feb 21, 2020
kindsun pushed a commit to kindsun/kibana that referenced this pull request Feb 21, 2020
…ion (elastic#58128)

* Remove old route ref, no longer used

* Use core elasticsearch service

* Remove getSavedObjectsRepository, use NP internalRepository

* Update tests and clean up

* Remove unused test vars
mbondyra added a commit to mbondyra/kibana that referenced this pull request Feb 22, 2020
…_improve-advanced-settings-save

* commit '98aa1d2d4f974f72a9a5397b1b91f11509f6fb7a':
  [SIEM] [Case] Enable case by default. Snake to camel on UI (elastic#57936)
  [File upload] Update remaining File Upload dependencies for NP migration (elastic#58128)
  Use EuiTokens for ES field types (elastic#57911)
  Added UI support for the default action group for Alert Type Model (elastic#57603)
  force savedObject API consumers to define SO type explicitly (elastic#58022)
  Update dependency @elastic/charts to ^17.1.1 (elastic#57634)
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 22, 2020
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

jloleysens added a commit to jloleysens/kibana that referenced this pull request Feb 24, 2020
…-out-of-legacy

* 'master' of github.com:elastic/kibana:
  [SIEM] [Case] Enable case by default. Snake to camel on UI (elastic#57936)
  [File upload] Update remaining File Upload dependencies for NP migration (elastic#58128)
  Use EuiTokens for ES field types (elastic#57911)
  Added UI support for the default action group for Alert Type Model (elastic#57603)
  force savedObject API consumers to define SO type explicitly (elastic#58022)
  Update dependency @elastic/charts to ^17.1.1 (elastic#57634)
  [Endpoint] Add a flyout to alert list. (elastic#57926)
  Make sure index pattern has fields before parsing (elastic#58242)
  Sanitize workpad before sending to API (elastic#57704)
  [ML] Transform: Support multi-line JSON notation in advanced editor (elastic#58015)
  [Endpoint] Refactor Management List Tests (elastic#58148)
  [kbn/optimizer] include bootstrap cache key in optimizer cache key (elastic#58176)
  Do not refresh color scale on each lookup (elastic#57792)
  Updating to @elastic/lodash@3.10.1-kibana4 (elastic#54662)
  Trigger context (elastic#57870)
  [ML] Transforms: Adds clone feature to transforms list. (elastic#57837)
  [ML] New Platform server shim: update fields service routes (elastic#58060)
  [Endpoint] EMT-184: change endpoints to metadata up and down the code base. (elastic#58038)
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 24, 2020
kindsun pushed a commit that referenced this pull request Feb 24, 2020
…ion (#58128) (#58297)

* Remove old route ref, no longer used

* Use core elasticsearch service

* Remove getSavedObjectsRepository, use NP internalRepository

* Update tests and clean up

* Remove unused test vars

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:File Upload Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v7.7.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants