[ML] New Platform server shim: update job service schema#57614
Merged
spalger merged 1 commit intoelastic:masterfrom Feb 13, 2020
Merged
Conversation
alvarezmelissa87
added
:ml
Feature:NP Migration
release_note:skip
Contributor
|
Pinging @elastic/ml-ui (:ml) |
Contributor
|
Alright, this looks good and will hopefully fix one of the failures in master right now. |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Feb 13, 2020
* master: (22 commits) skip flaky suite (elastic#50018) skip settings tests (elastic#57608) skip failing suite (elastic#44631) [SIEM] [Case] Initial UI (elastic#57283) handle viewing sample dashboards on default dist (elastic#57510) Fix detection of "system requests" in plugins (elastic#57149) [ML] New Platform server shim: update job service schema (elastic#57614) skip flaky suite (elastic#44631) [APM] Update monospace font family variable (elastic#57555) skip flaky test (elastic#57377) Skip save query tests (elastic#57589) [Maps] allow simultaneous opening of multiple tooltips (elastic#57226) [Uptime] Fix/host connected components (elastic#56969) [logs][metrics][docs] Update screenshots for 7.6 (elastic#57254) [ML] New Platform server shim: update job service routes to use new platform router (elastic#57403) [Maps] Fix document source top hits split by scripted field (elastic#57481) Use log4j pattern syntax (elastic#57433) [ML] Categorization field example endpoint tests (elastic#57471) [Lens] Filter out pinned filters from saved object of Lens (elastic#57197) Lens client side shim cleanup (elastic#56976) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates analyzerSchema to handle
filterbeing possibly undefined. Ensures categorization field example endpoint tests passNOTE:
This PR updates master to match a schema update that is already in 7.x.
This update to the schema was added to the backport for NP migration for job service routes #57403 to allow CI to pass.
Master did not get the change as the original PR passed CI and was able to be merged because it passed before the tests for the api were added (#57471).
The backport for those tests (#57566) was merged before the backport for the job service route migration.
To solve this, I added the schema adjustment directly to the backport (#57595) so CI could pass and then created this PR to make that same update to master.
Checklist
Delete any items that are not applicable to this PR.