[SIEM] [Case] Initial UI#57283
Merged
stephmilovic merged 80 commits intoelastic:masterfrom Feb 13, 2020
Merged
Conversation
XavierM
reviewed
Feb 13, 2020
x-pack/legacy/plugins/siem/public/pages/case/components/case_view/index.tsx
Outdated
Show resolved
Hide resolved
XavierM
reviewed
Feb 13, 2020
x-pack/legacy/plugins/siem/public/pages/case/components/shared_imports.ts
Show resolved
Hide resolved
XavierM
reviewed
Feb 13, 2020
x-pack/legacy/plugins/siem/public/pages/case/components/tag_list/index.tsx
Outdated
Show resolved
Hide resolved
XavierM
reviewed
Feb 13, 2020
x-pack/legacy/plugins/siem/public/pages/case/components/tag_list/index.tsx
Outdated
Show resolved
Hide resolved
XavierM
reviewed
Feb 13, 2020
x-pack/legacy/plugins/siem/public/pages/case/components/user_list/index.tsx
Show resolved
Hide resolved
XavierM
reviewed
Feb 13, 2020
XavierM
reviewed
Feb 13, 2020
XavierM
reviewed
Feb 13, 2020
XavierM
reviewed
Feb 13, 2020
...ins/siem/public/pages/detection_engine/rules/all/rules_table_filters/tags_filter_popover.tsx
Outdated
Show resolved
Hide resolved
XavierM
reviewed
Feb 13, 2020
...ins/siem/public/pages/detection_engine/rules/all/rules_table_filters/tags_filter_popover.tsx
Outdated
Show resolved
Hide resolved
XavierM
reviewed
Feb 13, 2020
XavierM
reviewed
Feb 13, 2020
XavierM
reviewed
Feb 13, 2020
XavierM
reviewed
Feb 13, 2020
| } | ||
| }, []); | ||
|
|
||
| export const convertTagsToSet = (tagObjects: Array<SavedObject<CaseAttributes>>): Set<string> => { |
Contributor
There was a problem hiding this comment.
nit ->
export const convertTagsToSet = (tagObjects: object[]): Set<string> =>
tagObjects.reduce<Set<string>>((accum, tagObj) => {
if (isTags(tagObj)) {
tagObj.attributes.tags.forEach(accum.add, accum);
}
return accum;
}, new Set());
XavierM
reviewed
Feb 13, 2020
XavierM
approved these changes
Feb 13, 2020
Contributor
XavierM
left a comment
There was a problem hiding this comment.
LGTM 🚀 💪 🚀 💪 🚀
Thank you for going over the code with me and keep me up to date with your code. This is really a nice jump to our case.
Contributor
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/advanced_settings/feature_controls/advanced_settings_security·ts.Advanced Settings security feature controls no advanced_settings privileges does not allow navigation to advanced settings; redirects to management homeStandard OutStack TraceHistory
To update your PR or re-run it, just comment with: |
stephmilovic
added a commit
to stephmilovic/kibana
that referenced
this pull request
Feb 13, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Feb 13, 2020
* master: (22 commits) skip flaky suite (elastic#50018) skip settings tests (elastic#57608) skip failing suite (elastic#44631) [SIEM] [Case] Initial UI (elastic#57283) handle viewing sample dashboards on default dist (elastic#57510) Fix detection of "system requests" in plugins (elastic#57149) [ML] New Platform server shim: update job service schema (elastic#57614) skip flaky suite (elastic#44631) [APM] Update monospace font family variable (elastic#57555) skip flaky test (elastic#57377) Skip save query tests (elastic#57589) [Maps] allow simultaneous opening of multiple tooltips (elastic#57226) [Uptime] Fix/host connected components (elastic#56969) [logs][metrics][docs] Update screenshots for 7.6 (elastic#57254) [ML] New Platform server shim: update job service routes to use new platform router (elastic#57403) [Maps] Fix document source top hits split by scripted field (elastic#57481) Use log4j pattern syntax (elastic#57433) [ML] Categorization field example endpoint tests (elastic#57471) [Lens] Filter out pinned filters from saved object of Lens (elastic#57197) Lens client side shim cleanup (elastic#56976) ...
9 tasks
Closed
patrykkopycinski
pushed a commit
that referenced
this pull request
Feb 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is the initial UI for Case Workflows. Please note this is a work in progress and is UI development done before receiving the designs. Therefore, unit tests were not written as it is mostly all temporary. The only page that I've started matching up with the designs is the Case View. I need to PR so that @cnasikas and @XavierM can start to help turn this unruly beast into our MVP. This is highly incomplete. Here is what we're looking at...
All Cases View
There is some basic table functionality programmed here. Sorting on the Opened/Updated/State fields, pagination, etc. I'm not happy with how the table flashes between loads right now, that will be addressed.
@cnasikas helped out by implementing filtering by tags
I started to implement search. However, it's pretty buggy with saved objects. I'm just using the SO find with search: 'plain string'. Not specifying fields. However, it's just not picking up some searches. check out these inconsistencies. Sometimes it searches title, sometimes it does not.
Create new case
I've got a view to create a new case. Nothing too fancy here yet. I need to get our existing tags to autosuggest.
Case view
This is the one view I started matching up to Michael's design. If I add tests to this PR, it will be around this area. Here are the things that are working on this page:
Here are the things that do not yet work, most drop down options and email alerts:
Running the branch
Attention: Additional configuration is required to run this PR!! We are still using the legacy platform for Saved Object mappings, so a bit of weirdness needs to happen:
x-pack/legacy/plugins/siem/index.ts- Add this value to the uiExports object beneath themappingskey:config/kibana.dev.yml- Add the following lines to your dev.yml:x-pack/legacy/plugins/siem/public/pages/home/home_navigations.tsxchange line 58 to