Skip to content

Plugin installer 4.x shoehorn#5755

Merged
BigFunger merged 5 commits intoelastic:4.xfrom
BigFunger:plugin-installer-4.x-shoehorn
Dec 22, 2015
Merged

Plugin installer 4.x shoehorn#5755
BigFunger merged 5 commits intoelastic:4.xfrom
BigFunger:plugin-installer-4.x-shoehorn

Conversation

@BigFunger
Copy link
Copy Markdown
Contributor

@BigFunger BigFunger commented Dec 22, 2015

Major shoehorn attempt to merge the commits from
#5438
#5668
#5592

and get them to play nice in 4.x

@epixa epixa mentioned this pull request Dec 22, 2015
Merged
@epixa
Copy link
Copy Markdown
Contributor

epixa commented Dec 22, 2015

LGTM

@epixa epixa assigned BigFunger and unassigned epixa Dec 22, 2015
@jbudz
Copy link
Copy Markdown
Contributor

jbudz commented Dec 22, 2015

Having issues installing plugins,

./bin/kibana plugin --install elastic/sense
Installing sense
Attempting to transfer from https://download.elastic.co/elastic/sense/sense-latest.tar.gz
Transferring 318236 bytes....................
Transfer complete
Plugin installation was unsuccessful due to error "Unsupported archive format."

@spalger
Copy link
Copy Markdown
Contributor

spalger commented Dec 22, 2015

Same here

image

@epixa
Copy link
Copy Markdown
Contributor

epixa commented Dec 22, 2015

Can one of you verify that installing plugins works on master?

@jbudz
Copy link
Copy Markdown
Contributor

jbudz commented Dec 22, 2015

It doesn't, same error. I can verify that 4.x without this pr does work.

@spalger spalger mentioned this pull request Dec 22, 2015
Merged
@BigFunger BigFunger assigned jbudz and unassigned BigFunger Dec 22, 2015
@spalger
Copy link
Copy Markdown
Contributor

spalger commented Dec 22, 2015

LGTM

jbudz
jbudz reviewed Dec 22, 2015
View reviewed changes
Comment thread package.json
Copy link
Copy Markdown
Contributor

@jbudz jbudz Dec 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we lock this version?

Copy link
Copy Markdown
Contributor

@epixa epixa Dec 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since that is in master, can we address that in a follow-up PR? This is just a backport, and it's already pretty monolithic.

Copy link
Copy Markdown
Contributor

@jbudz jbudz Dec 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep

@jbudz
Copy link
Copy Markdown
Contributor

jbudz commented Dec 22, 2015

LGTM

@jbudz jbudz assigned BigFunger and unassigned jbudz Dec 22, 2015
BigFunger added a commit that referenced this pull request Dec 22, 2015
@BigFunger
Merge pull request #5755 from BigFunger/plugin-installer-4.x-shoehorn
ce48099 
Plugin installer 4.x backport
@BigFunger BigFunger merged commit ce48099 into elastic:4.x Dec 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@BigFunger BigFunger

Labels

review v4.4.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BigFunger @epixa @jbudz @spalger