Plugin zip support#5438
Merged
BigFunger merged 11 commits intoelastic:masterfrom Dec 21, 2015
Merged
Conversation
Contributor
|
Heads up: We need to cut a 4.3 branch before we can merge 4.4 features |
BigFunger
force-pushed
the
plugin-zip-support-4.4.0
branch
4 times, most recently
from
2a23af2 to
7c06d08
Compare
BigFunger
force-pushed
the
plugin-zip-support-4.4.0
branch
from
7c06d08 to
4548be8
Compare
Contributor
|
LGTM |
Contributor
|
@BigFunger where would I get a zip to test this? Should it work with a zip downloaded from a plugin's github repo? |
Contributor
Author
|
@Bargs Yes. The zip from a plugin's github repo should work. I just tested this with the repo for my plugin: |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4512
Fixes #4720
Replaces #4975