[SIEM] Refactors Data Providers Cypress tests#57474
Merged
MadameSheema merged 1 commit intoelastic:masterfrom Feb 13, 2020
Merged
[SIEM] Refactors Data Providers Cypress tests#57474MadameSheema merged 1 commit intoelastic:masterfrom
MadameSheema merged 1 commit intoelastic:masterfrom
Conversation
MadameSheema
added
Team:SIEM
v8.0.0
release_note:skip
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
Contributor
💚 Build SucceededTo update your PR or re-run it, just comment with: |
rylnd
approved these changes
Feb 12, 2020
Contributor
rylnd
left a comment
rylnd
left a comment
There was a problem hiding this comment.
Nice improvements! Much more expressive and legible.
I like the convention of selectors.ts files containing query selectors, which it looks like we're straying from a bit, here. It would be nice to start converging on some patterns like that to aid other contributors. The concept of a sibling actions.ts might be a nice place for those new imperative helpers, as well!
MadameSheema
added a commit
to MadameSheema/kibana
that referenced
this pull request
Feb 13, 2020
MadameSheema
added a commit
that referenced
this pull request
Feb 13, 2020
mbondyra
added a commit
to mbondyra/kibana
that referenced
this pull request
Feb 13, 2020
* master: (22 commits) Use log4j pattern syntax (elastic#57433) [ML] Categorization field example endpoint tests (elastic#57471) [Lens] Filter out pinned filters from saved object of Lens (elastic#57197) Lens client side shim cleanup (elastic#56976) [Maps] do not show border color for icon in legend when border width is zero (elastic#57501) refactors 'data-providers' tests (elastic#57474) add `absolute` option to `getUrlForApp` (elastic#57193) [Telemetry] Migrate public to NP (elastic#56285) address flaky test where instances might have different start… (elastic#57506) fix(NA): support legacy plugins path in plugins (elastic#57472) build immutable bundles for new platform plugins (elastic#53976) [SIEM] [Detection Engine] Reject if duplicate rule_id in request payload (elastic#57057) Add autocomplete="off" for input type="password" to appease the scanners (elastic#56922) Use default spaces suffix for signals index if spaces disabled (elastic#57244) [Alerting] Create alert design cleanup (elastic#56929) Management Api - add to migration guide (elastic#56892) fixing maps (elastic#56706) [Maps] Autocomplete for custom color palettes and custom icon palettes (elastic#56446) [Alerting] make actionGroup name's i18n-able (elastic#57404) fixed flaky test (elastic#57490) ... # Conflicts: # src/legacy/core_plugins/telemetry/public/components/__snapshots__/telemetry_form.test.js.snap # src/plugins/telemetry/public/components/telemetry_management_section.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors Data Providers Cypress tests in order to follow the new guidelines.