[Telemetry] Migrate public to NP by Bamieh · Pull Request #56285 · elastic/kibana

Bamieh · 2020-01-29T12:03:13Z

Fully migrates telemetry public to NP (Closes #45428)

Important Notes:

I've improved the tests we have for telemetry/public a lot in the PR. This PR mainly moves the current code from old platform to NP so we can open an issue to add more test coverage in future PRs.
Management section wrapper is not moved to NP since this management plugin feature is still in legacy. The management component and everything inside the wrapper is fully migrated to NP in the telemetry plugin.
Moved handling of old settings from public to server. This way we reduce fetching 3 requests on every page load. This will happen once on kibana init and moves old flags to the current opt In saved object, copying the behavior we had in previous kibana releases.
Preivously we used to hide the banner in the status page. We hide the banner in that page since it can be accessed without a login under a kibana configuration. This is no longer needed since anonymousPaths.isAnonymous will add the status page if that config is set.
Opting in/out under advanced settings no longer requires a page refresh to work properly after a settings change.
Welcome screen in homepage will not show any telemetry related information when telemetry.enabled is set to false:
Split the previous monolith telemetryProvider implementation into two main services under NP:
1. telemetryService for fetching configurations and sending telemetry
2. telemetryNotifications for handling all telemetry notifications and banners.
Internationalized Opted in banner title when migrating the component (closes [i18n] Missing i18n for telemetry banner #55907)
Adds missing field settings to usage statistics advanced settings (closes data-test-subj's and other attributes undefined in Usage Data advanced setting #54968)
Fixed flaky tests for browser telemetry sender (closes telemetry class _checkReportStatus returns false if last report is too recent #27922)

…rate_public

elasticmachine · 2020-01-29T12:03:16Z

Pinging @elastic/pulse (Team:Pulse)

src/plugins/telemetry/public/services/telemetry_service.ts

src/plugins/telemetry/public/services/telemetry_sender.ts

…rate_public

pgayvallet · 2020-01-31T07:30:25Z

Please ping the platform team again when the PR is ready for review.

…rate_public

tsullivan · 2020-02-10T18:53:13Z

x-pack/test/reporting/functional/reporting.js


-          await PageObjects.dashboard.switchToEditMode();
+          await PageObjects.common.navigateToApp('dashboard');
+          await PageObjects.dashboard.gotoDashboardEditMode('My PNG Dash');


Thanks for catching this, and sorry you had to go through it. There definitely is an issue with the Reporting functional tests in that they have overcomplicated steps that could be worked around by using smarter archives of the objects being reported on.

x-pack/.gitignore

test/functional/config.js

joshdover

Platform integration points LGTM

tsullivan

Approved from the side reporting functional test changes. Thanks for not just skipping the test!

flash1293

Kibana app changes LGTM, thanks a lot for this. We are so close to migrate home to the new platform now 🎉

src/legacy/core_plugins/kibana/public/home/np_ready/components/welcome.test.tsx

…rate_public

afharo

It looks great to me! Just 2 NITs. Please, feel free to merge if they are not valid comments.

src/plugins/telemetry/public/components/telemetry_management_section.tsx

src/plugins/telemetry/public/plugin.ts

…ection.tsx Co-Authored-By: Alejandro Fernández Haro <afharo@gmail.com>

Bamieh · 2020-02-12T20:59:22Z

@elasticmachine merge upstream

Bamieh · 2020-02-13T04:37:25Z

@elasticmachine merge upstream

kibanamachine · 2020-02-13T06:16:36Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: d5847da

History

💔 Build #26176 failed cd70972
💔 Build #26134 failed d1238c4
💚 Build #26048 succeeded d872f94
💔 Build #25936 failed 6b021b0
💚 Build #25654 succeeded 50f3cca

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* master: add `absolute` option to `getUrlForApp` (elastic#57193) [Telemetry] Migrate public to NP (elastic#56285) address flaky test where instances might have different start… (elastic#57506) fix(NA): support legacy plugins path in plugins (elastic#57472) build immutable bundles for new platform plugins (elastic#53976) [SIEM] [Detection Engine] Reject if duplicate rule_id in request payload (elastic#57057) Add autocomplete="off" for input type="password" to appease the scanners (elastic#56922) Use default spaces suffix for signals index if spaces disabled (elastic#57244) [Alerting] Create alert design cleanup (elastic#56929)

* master: (22 commits) Use log4j pattern syntax (elastic#57433) [ML] Categorization field example endpoint tests (elastic#57471) [Lens] Filter out pinned filters from saved object of Lens (elastic#57197) Lens client side shim cleanup (elastic#56976) [Maps] do not show border color for icon in legend when border width is zero (elastic#57501) refactors 'data-providers' tests (elastic#57474) add `absolute` option to `getUrlForApp` (elastic#57193) [Telemetry] Migrate public to NP (elastic#56285) address flaky test where instances might have different start… (elastic#57506) fix(NA): support legacy plugins path in plugins (elastic#57472) build immutable bundles for new platform plugins (elastic#53976) [SIEM] [Detection Engine] Reject if duplicate rule_id in request payload (elastic#57057) Add autocomplete="off" for input type="password" to appease the scanners (elastic#56922) Use default spaces suffix for signals index if spaces disabled (elastic#57244) [Alerting] Create alert design cleanup (elastic#56929) Management Api - add to migration guide (elastic#56892) fixing maps (elastic#56706) [Maps] Autocomplete for custom color palettes and custom icon palettes (elastic#56446) [Alerting] make actionGroup name's i18n-able (elastic#57404) fixed flaky test (elastic#57490) ... # Conflicts: # src/legacy/core_plugins/telemetry/public/components/__snapshots__/telemetry_form.test.js.snap # src/plugins/telemetry/public/components/telemetry_management_section.tsx

elasticmachine · 2021-10-01T21:41:46Z

Pinging @elastic/kibana-core (Team:Core)

Bamieh added 4 commits January 27, 2020 13:24

NP telemetry plugin barebones

4602235

Merge branch 'master' of github.com:elastic/kibana into telemetry/mig…

45d39de

…rate_public

fully migrate telemetry sender

cc39460

Merge branch 'master' of github.com:elastic/kibana into telemetry/mig…

9438a19

…rate_public

Bamieh added Feature:New Platform Feature:Telemetry v8.0.0 v7.7.0 Team:Pulse labels Jan 29, 2020

Bamieh requested review from a team January 29, 2020 12:03

TinaHeiligers reviewed Jan 29, 2020

View reviewed changes

src/plugins/telemetry/public/services/telemetry_service.ts Show resolved Hide resolved

afharo requested changes Jan 29, 2020

View reviewed changes

src/plugins/telemetry/public/services/telemetry_sender.ts Show resolved Hide resolved

Bamieh added 6 commits January 29, 2020 23:27

license plugin to use NP telemetry

4841c72

merge master

8cf5605

Merge branch 'master' of github.com:elastic/kibana into telemetry/mig…

04b496b

…rate_public

fully migrated public to NP

980fae1

Merge branch 'master' of github.com:elastic/kibana into telemetry/mig…

2da7f87

…rate_public

finish components testing

f16ef88

Bamieh added 2 commits January 31, 2020 16:34

fix all tests

7bdb667

Merge branch 'master' of github.com:elastic/kibana into telemetry/mig…

48b572c

…rate_public

Bamieh marked this pull request as ready for review January 31, 2020 14:35

Bamieh requested a review from a team January 31, 2020 14:35

Bamieh added 2 commits January 31, 2020 16:47

self code review

9f7e69b

remove commented code

b7ef413

Bamieh requested review from TinaHeiligers and afharo January 31, 2020 14:51

Bamieh added the release_note:skip Skip the PR/issue when compiling release notes label Jan 31, 2020

tsullivan reviewed Feb 10, 2020

View reviewed changes

Bamieh commented Feb 10, 2020

View reviewed changes

x-pack/.gitignore Show resolved Hide resolved

Bamieh commented Feb 10, 2020

View reviewed changes

test/functional/config.js Show resolved Hide resolved

Bamieh added 2 commits February 11, 2020 18:44

merge master

3420be7

merge master

6b021b0

joshdover approved these changes Feb 11, 2020

View reviewed changes

tsullivan approved these changes Feb 11, 2020

View reviewed changes

flash1293 approved these changes Feb 11, 2020

View reviewed changes

src/legacy/core_plugins/kibana/public/home/np_ready/components/welcome.test.tsx Outdated Show resolved Hide resolved

Bamieh added 4 commits February 12, 2020 00:11

escape unused forced types in Field

1f7593c

Merge branch 'master' of github.com:elastic/kibana into telemetry/mig…

d872f94

…rate_public

Merge branch 'master' of github.com:elastic/kibana into telemetry/mig…

6ac8b4e

…rate_public

rename mock to mocks for eslint

d1238c4

afharo approved these changes Feb 12, 2020

View reviewed changes

src/plugins/telemetry/public/components/telemetry_management_section.tsx Outdated Show resolved Hide resolved

src/plugins/telemetry/public/plugin.ts Show resolved Hide resolved

Bamieh and others added 2 commits February 12, 2020 15:59

Update src/plugins/telemetry/public/components/telemetry_management_s…

cd70972

…ection.tsx Co-Authored-By: Alejandro Fernández Haro <afharo@gmail.com>

fix save/clear type

aaae6c5

Merge branch 'master' into telemetry/migrate_public

55a797c

Merge branch 'master' into telemetry/migrate_public

d5847da

Bamieh merged commit 06df2b0 into elastic:master Feb 13, 2020

Bamieh deleted the telemetry/migrate_public branch February 13, 2020 07:44

Bamieh mentioned this pull request Feb 13, 2020

[7.x] [Telemetry] Migrate public to NP (#56285) #57534

Merged

Bamieh added a commit that referenced this pull request Feb 13, 2020

[7.x] [Telemetry] Migrate public to NP (#56285) (#57534)

d02fb7a

joshdover mentioned this pull request Mar 16, 2020

Expose active app name to plugins #44868

Closed

lukeelmers added the Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// label Oct 1, 2021

lukeelmers removed the Team:KibanaTelemetry label Oct 1, 2021

Conversation

Bamieh commented Jan 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Jan 29, 2020

Uh oh!

Uh oh!

Uh oh!

pgayvallet commented Jan 31, 2020

Uh oh!

tsullivan Feb 10, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

joshdover left a comment

Choose a reason for hiding this comment

Uh oh!

tsullivan left a comment

Choose a reason for hiding this comment

Uh oh!

flash1293 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

afharo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Bamieh commented Feb 12, 2020

Uh oh!

Bamieh commented Feb 13, 2020

Uh oh!

kibanamachine commented Feb 13, 2020

💚 Build Succeeded

History

Uh oh!

elasticmachine commented Oct 1, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Bamieh commented Jan 29, 2020 •

edited

Loading