-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Pipeline refactoring #56447
[CI] Pipeline refactoring #56447
Conversation
@spalger particularly interested in hearing from you about whether or not this seems to make things clearer without re-writing everything, since you've probably looked at the Pipeline code the most |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
def esPort = "61${workerNumber}2" | ||
def esTransportPort = "61${workerNumber}3" | ||
def functionalTestProcess(String name, Closure closure) { | ||
return { processNumber -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a strong opinion on the refactoring, but the changes LGTM. The build information in jenkins looks the same, code changes look good.
Should the es snapshot run the same timeout as kibana? or is it minus the accessibility test time?
@elasticmachine merge upstream |
The ES snapshot job is a little shorter than the main pipeline job just because the main job has flaky test retries turned on (which can increase the overall build time, in the worst case, but usually doesn't), and the snapshot job currently does not. |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
merge conflict between base and head |
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/discover/_discover·js.discover app discover test "before all" hook in "discover test"Standard Out
Stack Trace
Kibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/discover/_discover·js.discover app discover test "before all" hook in "discover test"Standard Out
Stack Trace
History
To update your PR or re-run it, just comment with: |
@@ -1,5 +1,5 @@ | |||
def print() { | |||
try { | |||
catchError(catchInterruptions: false, buildResult: null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, reminds me of:
export const tryCatch = f => {
try {
return Right(f());
} catch (e) {
return Left(e);
}
};
Pinging @elastic/kibana-operations (Team:Operations) |
* master: (26 commits) [Endpoint] Alert Details Overview (elastic#58412) Service map language icons (elastic#58633) [SIEM] [Case] Comments to case view (elastic#58315) Remove appBasePath from docs + add mock for AppMountParameters (elastic#58775) [kbn/optimizer] fix ui/* url rewrites in dist (elastic#58627) Dashboard a11y tests (elastic#58122) Downgrade "setting up plugin" log to debug (elastic#58776) [CI] Pipeline refactoring (elastic#56447) [Advanced Settings] Fix a11y of unsaved indicator (elastic#58511) put params into short url instead of behind it (elastic#58846) show timepicker in timelion and tsvb (elastic#58857) improve graph missing workspace error message (elastic#58876) [Maps] direct Discover "visualize" to open Maps application (elastic#58549) Disallow duplicate percentiles (elastic#57444) (elastic#58299) removing references to visTypes uiExports (elastic#58337) [SIEM] Default the Timeline events filter to show All events (elastic#58953) [Remote clusters] Add indexManagement as required plugin (elastic#58915) [DOCS] Rework of main get started page (elastic#58260) [Endpoint] [Tests] fixes elastic#57946 flaky endpoint policy list test (elastic#58348) [Endpoint] add resolver middleware (elastic#58288) ...
* master: Dashboard a11y tests (elastic#58122) Downgrade "setting up plugin" log to debug (elastic#58776) [CI] Pipeline refactoring (elastic#56447) [Advanced Settings] Fix a11y of unsaved indicator (elastic#58511) put params into short url instead of behind it (elastic#58846) show timepicker in timelion and tsvb (elastic#58857) improve graph missing workspace error message (elastic#58876)
Mostly trying to make terminology, etc less confusing, more consistent, and easier to follow. Open to suggestions for changes. Also just getting rid of some cruft that has accumulated since launch of pipelines.
worker = a jenkins agent / gobld worker, with some bootstrapping/setup depending on the worker type
process = something that runs on a worker, probably in parallel (e.g.
ossCiGroupProcess
)Also fixes a few small things:
catchError {}
should ignore job aborts in almost all cases, this should hopefully make it easier to abort jobs on the first tryI have also been testing this with the flaky-test-suite-runner job and on my Jenkins sandbox with the ES snapshot jobs, and so far so good.