[Discover] Inline angular directives only used in this plugin by kertal · Pull Request #56119 · elastic/kibana

kertal · 2020-01-28T10:37:45Z

Summary

The following imports are only used by discover and are inlined into the discover plugin by this PR

ui/directives/field_name/field_name
ui/directives/listen/listen - it's also used by timelion and maps
ui/collapsible_sidebar/collapsible_sidebar
ui/directives/css_truncate
ui/fixed_scroll
ui/directives/debounce/debounce
ui/render_complete/directive

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, including a check against IE11~~
~~- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support~~
~~- [ ] Documentation was added for features that require explanation or tutorials~~
~~- [ ] Unit or functional tests were updated or added to match the most common scenarios~~
~~- [ ] This was checked for keyboard-only and screenreader accessibility~~

For maintainers

~~- [ ] This was checked for breaking API changes and was labeled appropriately~~
~~- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately~~

…-28-discover_inline_static_code_deps

kertal · 2020-01-30T08:45:22Z

src/legacy/core_plugins/kibana/public/discover/np_ready/angular/directives/_index.scss

 @import 'no_results';
-@import 'histogram';
+@import 'histogram';
+@import './collapsible_sidebar/index';


dear @elastic/kibana-design, no new SCSS inside, just change of path and imports

I just reviewed the SCSS files that were moved to a new directory and LGTM!

kertal · 2020-01-30T08:47:11Z

Jenkins, test this - seems to be a unrelated error

kertal · 2020-01-30T08:59:40Z

@elasticmachine merge upstream

…c_code_deps

flash1293

Tested and everything still seems to work - LGTM

flash1293 · 2020-01-31T13:11:18Z

...cy/core_plugins/kibana/public/discover/np_ready/angular/directives/field_name/field_name.tsx

 // @ts-ignore
-import { shortenDottedString } from '../../../../core_plugins/kibana/common/utils/shorten_dotted_string';
-import { FieldIcon } from '../../../../../../src/plugins/kibana_react/public';
+import { shortenDottedString } from '../../../../../../common/utils/shorten_dotted_string';


It seems like shorten_dotted_string is also available from the data plugin src/plugins/data/common/utils/shorten_dotted_string.ts

Thanks for that hint! Done! Goodbye to another @ts-ignore, another brick in our old-kibana-wall. think we could now start to plan a museum of old code fragments. before everybody forgets.

…-28-discover_inline_static_code_deps

…of github.com:kertal/kibana into kertal-pr-2020-01-28-discover_inline_static_code_deps

kertal · 2020-02-04T06:38:13Z

@elasticmachine merge upstream

…c_code_deps

kibanamachine · 2020-02-04T07:57:40Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: c831da1

History

💚 Build #23716 succeeded 8ad930e
💚 Build #23459 succeeded 79f4e19
💔 Build #23450 failed ef7fd1f
💔 Build #23380 failed 9d0b238
💔 Build #23256 failed 1e76512

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kertal · 2020-02-04T13:15:59Z

thx @miukimiu, @flash1293 for the reviews, time to merge!

…c#56119) * Migrate field_name directive * Migrate collapsible_sidebar directive * Fix FieldName import at table_row.tsx * Migrate css_truncate directive * Migrate fixed_scroll & debounce directives * Migrate render_complete directive * Fix css_truncate test * Use shortenDottedString in the TypesScript version

* master: (42 commits) Move kuery_autocomplete ⇒ NP (elastic#56607) [ML] Functional tests - stabilize job row and analytics result view assertions (elastic#56595) [Discover] Inline angular directives only used in this plugin (elastic#56119) [Discover] Migrate get_sort.js test from mocha to TypeScript (elastic#56011) [SIEM] Enable flow_target_select_connected unit tests (elastic#55618) Start consuming np logging config (elastic#56480) [SIEM] Add eslint-plugin-react-perf (elastic#55960) Mention changed SAML ACS endpoint URL in breaking changes doc. (elastic#56613) Add `getServerInfo` API to http setup contract (elastic#56636) Updates Monitoring alert Jest snapshots Kibana property config migrations (elastic#55937) Vislib replacement toggle (elastic#56439) [Uptime] Add unit tests for QueryContext time calculation (elastic#56671) [SIEM][Detection Engine] Critical blocker, fixes pre-packaged rule miscounts Upgrade EUI to v18.3.0 (elastic#56228) [Maps] Fix server log (elastic#56679) [SIEM] Fixes FTUE when APM node is present (elastic#56574) [Reporting/FieldFormats] expose `setFieldFormats` and call from ReportingPlugin.start (elastic#56563) Update EMS API urls for production (elastic#56657) Ability to delete alerts even when AAD is out of sync (elastic#56543) ...

#56744) * Migrate field_name directive * Migrate collapsible_sidebar directive * Fix FieldName import at table_row.tsx * Migrate css_truncate directive * Migrate fixed_scroll & debounce directives * Migrate render_complete directive * Fix css_truncate test * Use shortenDottedString in the TypesScript version

Migrate field_name directive

db6d546

kertal self-assigned this Jan 28, 2020

kertal added 2 commits January 28, 2020 13:24

Migrate collapsible_sidebar directive

50a011f

Fix FieldName import at table_row.tsx

fc68ebc

kertal changed the title ~~[Discover] Inline angular directive only used here~~ [Discover] Inline angular directives only used in this plugin Jan 28, 2020

kertal added 3 commits January 29, 2020 09:26

Migrate css_truncate directive

a5f3f6a

Migrate fixed_scroll & debounce directives

3f86f32

Migrate render_complete directive

f33ff2d

kertal added Feature:NP Migration Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0 labels Jan 29, 2020

kertal added 2 commits January 29, 2020 11:15

Merge remote-tracking branch 'upstream/master' into kertal-pr-2020-01…

1e76512

…-28-discover_inline_static_code_deps

Fix i18n

9d0b238

flash1293 mentioned this pull request Jan 29, 2020

Kibana app migration: Move static code dependencies into kibana_legacy plugin #50670

Closed

24 tasks

Fix css_truncate test

ef7fd1f

kertal marked this pull request as ready for review January 30, 2020 08:35

kertal requested a review from a team January 30, 2020 08:35

kertal requested a review from a team as a code owner January 30, 2020 08:35

kertal commented Jan 30, 2020

View reviewed changes

Merge branch 'master' into kertal-pr-2020-01-28-discover_inline_stati…

79f4e19

…c_code_deps

flash1293 approved these changes Jan 31, 2020

View reviewed changes

flash1293 reviewed Jan 31, 2020

View reviewed changes

kertal added 3 commits January 31, 2020 14:42

Use shortenDottedString in the TypesScript version

8285b2a

Merge remote-tracking branch 'upstream/master' into kertal-pr-2020-01…

0217876

…-28-discover_inline_static_code_deps

Merge branch 'kertal-pr-2020-01-28-discover_inline_static_code_deps' …

8ad930e

…of github.com:kertal/kibana into kertal-pr-2020-01-28-discover_inline_static_code_deps

Merge branch 'master' into kertal-pr-2020-01-28-discover_inline_stati…

c831da1

…c_code_deps

kertal mentioned this pull request Feb 4, 2020

Move oss telemetry service into NP #56481

Merged

elizabetdev approved these changes Feb 4, 2020

View reviewed changes

kertal merged commit d73e15f into elastic:master Feb 4, 2020

kertal mentioned this pull request Feb 4, 2020

[7.x] [Discover] Inline angular directives only used in this plugin (#56119) #56744

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

[Discover] Inline angular directives only used in this plugin#56119

[Discover] Inline angular directives only used in this plugin#56119
kertal merged 14 commits intoelastic:masterfrom
kertal:kertal-pr-2020-01-28-discover_inline_static_code_deps

kertal commented Jan 28, 2020 •

edited

Loading

Uh oh!

kertal Jan 30, 2020

Uh oh!

elizabetdev Feb 4, 2020

Uh oh!

kertal commented Jan 30, 2020

Uh oh!

kertal commented Jan 30, 2020

Uh oh!

flash1293 left a comment

Uh oh!

flash1293 Jan 31, 2020 •

edited

Loading

Uh oh!

kertal Jan 31, 2020 •

edited

Loading

Uh oh!

kertal commented Feb 4, 2020

Uh oh!

kibanamachine commented Feb 4, 2020

Uh oh!

kertal commented Feb 4, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments

Conversation

kertal commented Jan 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

kertal Jan 30, 2020

Choose a reason for hiding this comment

Uh oh!

elizabetdev Feb 4, 2020

Choose a reason for hiding this comment

Uh oh!

kertal commented Jan 30, 2020

Uh oh!

kertal commented Jan 30, 2020

Uh oh!

flash1293 left a comment

Choose a reason for hiding this comment

Uh oh!

flash1293 Jan 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kertal Jan 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kertal commented Feb 4, 2020

Uh oh!

kibanamachine commented Feb 4, 2020

💚 Build Succeeded

History

Uh oh!

kertal commented Feb 4, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

kertal commented Jan 28, 2020 •

edited

Loading

flash1293 Jan 31, 2020 •

edited

Loading

kertal Jan 31, 2020 •

edited

Loading