[Discover] Migrate get_sort.js test from mocha to TypeScript#56011
Merged
kertal merged 6 commits intoelastic:masterfrom Feb 4, 2020
Merged
[Discover] Migrate get_sort.js test from mocha to TypeScript#56011kertal merged 6 commits intoelastic:masterfrom
kertal merged 6 commits intoelastic:masterfrom
Conversation
kertal
added
Feature:Discover
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
kertal
commented
Jan 28, 2020
| numeric_type?: 'double' | 'long' | 'date' | 'date_nanos'; | ||
| } | ||
|
|
||
| export type EsQuerySortValue = Record<string, SortDirection | SortDirectionNumeric>; |
Member
Author
There was a problem hiding this comment.
Note: Discover needs some advanced ES sorting props when sorting by date_nanos:
lizozom
approved these changes
Jan 29, 2020
Contributor
lizozom
left a comment
lizozom
left a comment
There was a problem hiding this comment.
Haven't tests, but @elastic/kibana-app-arch changes LGTM
flash1293
approved these changes
Jan 30, 2020
Contributor
flash1293
left a comment
flash1293
left a comment
There was a problem hiding this comment.
Code LGTM, didn't pull down to test.
Member
Author
|
@elasticmachine merge upstream |
Member
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Feb 4, 2020
…#56011) * Migrate get_sort.js test from mocha to jest and convert to TypeScript * Add jest test
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Feb 4, 2020
* master: (42 commits) Move kuery_autocomplete ⇒ NP (elastic#56607) [ML] Functional tests - stabilize job row and analytics result view assertions (elastic#56595) [Discover] Inline angular directives only used in this plugin (elastic#56119) [Discover] Migrate get_sort.js test from mocha to TypeScript (elastic#56011) [SIEM] Enable flow_target_select_connected unit tests (elastic#55618) Start consuming np logging config (elastic#56480) [SIEM] Add eslint-plugin-react-perf (elastic#55960) Mention changed SAML ACS endpoint URL in breaking changes doc. (elastic#56613) Add `getServerInfo` API to http setup contract (elastic#56636) Updates Monitoring alert Jest snapshots Kibana property config migrations (elastic#55937) Vislib replacement toggle (elastic#56439) [Uptime] Add unit tests for QueryContext time calculation (elastic#56671) [SIEM][Detection Engine] Critical blocker, fixes pre-packaged rule miscounts Upgrade EUI to v18.3.0 (elastic#56228) [Maps] Fix server log (elastic#56679) [SIEM] Fixes FTUE when APM node is present (elastic#56574) [Reporting/FieldFormats] expose `setFieldFormats` and call from ReportingPlugin.start (elastic#56563) Update EMS API urls for production (elastic#56657) Ability to delete alerts even when AAD is out of sync (elastic#56543) ...
kertal
added a commit
that referenced
this pull request
Feb 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Converting tests
get_sort.jsfrom Mocha to Jest, convertget_sort.jsto TypeScript. Refactor it to make this possible.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately