[Mappings editor] Clean up dynamic_templates code

[alisonelizabeth]

Addresses this comment: #54523 (comment)

How to review

• Confirm comment above is addressed as expected
• Confirm dynamic_templates functionality still works as expected

[elasticmachine]

Pinging @elastic/es-ui (Team:Elasticsearch UI)

[sebelga]

Thanks for making these changes @alisonelizabeth ! Tested locally and works as expected.

Testing this PR, I notice we have a small regression bug on the UI but it is not critical.
After the change to start using "tabs", the isStateValid() (in utils.ts) logic needs to be updated. Now, it always returns undefined, so when a tab is not valid (for example the dynamic templates), the Steps and the "Next" button are not disabled anymore.

[alisonelizabeth]

Testing this PR, I notice we have a small regression bug on the UI but it is not critical.
After the change to start using "tabs", the isStateValid() (in utils.ts) logic needs to be updated. Now, it always returns undefined, so when a tab is not valid (for example the dynamic templates), the Steps and the "Next" button are not disabled anymore.

Great catch! I'm opened #55051 since this bug wasn't introduced via this PR.

[alisonelizabeth]

@elasticmachine merge upstream

[elasticmachine]

user doesn't have permission to update head repository

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 55f9054

History

• 💔 Build #20658 failed 8d171e4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream