Skip to content

[Reporting/Mocha] Fix and unskip a test #54598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tsullivan merged 1 commit into from
Jan 14, 2020
Merged

[Reporting/Mocha] Fix and unskip a test #54598

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions x-pack/legacy/plugins/reporting/server/lib/esqueue/__tests__/helpers/cancellation_token.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@ import expect from '@kbn/expect';
import sinon from 'sinon';
import { CancellationToken } from '../../../../../common/cancellation_token';

Copy link
Copy Markdown
Contributor

@joelgriffith joelgriffith Jan 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if moving this to TS would help with these kinds of issues?

// FAILING: https://github.com/elastic/kibana/issues/51373
describe.skip('CancellationToken', function() {
describe('CancellationToken', function() {
let cancellationToken;
beforeEach(function() {
cancellationToken = new CancellationToken();
Expand Down Expand Up @@ -65,12 +64,12 @@ describe.skip('CancellationToken', function() {

describe('isCancelled', function() {
it('should default to false', function() {
expect(cancellationToken.isCancelled).to.be(false);
expect(cancellationToken.isCancelled()).to.be(false);
});

it('should switch to true after call to cancel', function() {
cancellationToken.cancel();
expect(cancellationToken.isCancelled).to.be(true);
expect(cancellationToken.isCancelled()).to.be(true);
});
});
});