[Reporting/Mocha] Fix and unskip a test#54598
Merged
tsullivan merged 1 commit intoelastic:masterfrom Jan 14, 2020
Merged
Conversation
tsullivan
added
zDeprecated Feature:Reporting
Contributor
|
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
tsullivan
added
the
release_note:skip
Contributor
💚 Build SucceededTo update your PR or re-run it, just comment with: |
| @@ -8,8 +8,7 @@ import expect from '@kbn/expect'; | |||
| import sinon from 'sinon'; | |||
| import { CancellationToken } from '../../../../../common/cancellation_token'; | |||
|
|
|||
Contributor
There was a problem hiding this comment.
I wonder if moving this to TS would help with these kinds of issues?
joelgriffith
approved these changes
Jan 14, 2020
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Jan 14, 2020
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Jan 14, 2020
tsullivan
added a commit
that referenced
this pull request
Jan 15, 2020
tsullivan
added a commit
that referenced
this pull request
Jan 15, 2020
jkelastic
pushed a commit
to jkelastic/kibana
that referenced
this pull request
Jan 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #51373