Skip to content

Lens: pass indexPatternId prop to ChangeIndexPattern to display selected current index pattern #52614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbondyra merged 2 commits into from
Dec 13, 2019
Merged

Lens: pass indexPatternId prop to ChangeIndexPattern to display selected current index pattern #52614

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5f4078
fix: pass indexPatterId to display selection
mbondyra Dec 10, 2019
2c4abd9
Merge branch 'master' into pass-index-pattern-id-for-datapanel
elasticmachine Dec 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions x-pack/legacy/plugins/lens/public/indexpattern_plugin/datapanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,7 @@ export const InnerIndexPatternDataPanel = function InnerIndexPatternDataPanel({
'data-test-subj': 'indexPattern-switch-link',
className: 'lnsInnerIndexPatternDataPanel__triggerButton',
}}
indexPatternId={currentIndexPatternId}
Copy link
Contributor

@majagrubic majagrubic Dec 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any tests for this?

Copy link
Contributor Author

@mbondyra mbondyra Dec 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both the datapanel.test.tsx and layerpanel.test.tsx test the behaviour of the inside of ChangeIndexPattern. The indexPatternId prop behaviour is already tested in layerpanel.test.tsx so I am not sure if the additional test is needed here 🤔

indexPatternRefs={indexPatternRefs}
onChangeIndexPattern={(newId: string) => {
onChangeIndexPattern(newId);
Expand Down