Lens: pass indexPatternId prop to ChangeIndexPattern to display selected current index pattern
#52614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbondyra
changed the title
indexPatternId prop to ChangeIndexPattern to display selection of current index pattern indexPatternId prop to ChangeIndexPattern to display selected current index pattern
mbondyra
added
release_note:skip
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
mbondyra
force-pushed
the
pass-index-pattern-id-for-datapanel
branch
from
f68d4eb to
d5f4078
Compare
majagrubic
reviewed
Dec 11, 2019
| 'data-test-subj': 'indexPattern-switch-link', | ||
| className: 'lnsInnerIndexPatternDataPanel__triggerButton', | ||
| }} | ||
| indexPatternId={currentIndexPatternId} |
Contributor
Author
There was a problem hiding this comment.
Both the datapanel.test.tsx and layerpanel.test.tsx test the behaviour of the inside of ChangeIndexPattern. The indexPatternId prop behaviour is already tested in layerpanel.test.tsx so I am not sure if the additional test is needed here 🤔
majagrubic
approved these changes
Dec 11, 2019
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
By passing
indexPatternIdto the component<ChangeIndexPattern/>we can see which index pattern is selected.Before & after:
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[x] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[x] Documentation was added for features that require explanation or tutorials[x] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately[ ] This includes a feature addition or change that requires a release note and was labeled appropriately