[Graph] Deangularize saved object handling (workspace) #52529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-22-np-saved-object
…-22-np-saved-object
Member
Author
|
jenkins, test this |
Member
Author
|
@elasticmachine merge upstream |
kertal
added
Feature:Graph
flash1293
approved these changes
Dec 13, 2019
Contributor
flash1293
left a comment
flash1293
left a comment
There was a problem hiding this comment.
Tested and still works fine - LGTM besides one small nit
| */ | ||
|
|
||
| export function extractReferences({ attributes, references = [] }) { | ||
| import { SavedObjectAttributes, SavedObjectReference } from 'kibana/server'; |
Contributor
There was a problem hiding this comment.
This should not be imported from the server as this is client side code: import { SavedObjectAttributes, SavedObjectReference } from 'kibana/public'; - this will soon trigger a linting error
Member
Author
There was a problem hiding this comment.
Thanks! 👍 I've changed that
…om:kertal/kibana into kertal-pr-2019-12-09-np-saved-object-graph
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up of #51562, deangularization and typescriptification of the
saved_objectusage ingraphChecklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately