Merge branch 'kertal-pr-2019-11-22-np-saved-object' into kertal-pr-2019-12-09-np-saved-object-graph

Author: kertal

src/legacy/core_plugins/kibana/public/discover/saved_searches/_saved_search.ts

@@ -32,6 +32,11 @@ export function createSavedSearchClass(services: SavedObjectKibanaServices) {
       sort: 'keyword',
       version: 'integer',
     };
+    // Order these fields to the top, the rest are alphabetical
+    public static fieldOrder = ['title', 'description'];
+    public static searchSource = true;
+
+    public id: string;
     public showInRecentlyAccessed: boolean;
 
     constructor(id: string) {

src/legacy/ui/public/saved_objects/saved_object.ts

@@ -42,20 +42,14 @@ export function createSavedObjectClass(services: SavedObjectKibanaServices) {
    * @param {*} config
    */
   class SavedObjectClass {
-    public static fieldOrder = ['title', 'description'];
-    public static searchSource = true;
-    public id?: string;
-    public title: string = '';
-    public getFullPath?: () => string;
-
     constructor(config: SavedObjectConfig = {}) {
       // @ts-ignore
       const self: SavedObject = this;
       buildSavedObject(self, config, services);
     }
   }
 
-  return SavedObjectClass;
+  return SavedObjectClass as new (config: SavedObjectConfig) => SavedObject;
 }
 // the old angular way, should be removed once no longer used
 export function SavedObjectProvider() {

src/legacy/ui/public/saved_objects/types.ts

@@ -17,7 +17,7 @@
  * under the License.
  */
 import { ChromeStart, OverlayStart, SavedObjectsClientContract } from 'kibana/public';
-import { SearchSourceContract } from 'ui/courier';
+import { SearchSource, SearchSourceContract } from 'ui/courier';
 import { SavedObjectAttributes, SavedObjectReference } from 'kibana/server';
 import { IndexPatternsContract } from '../../../../plugins/data/public';
 import { IndexPattern } from '../../../core_plugins/data/public';
@@ -83,7 +83,7 @@ export interface SavedObjectConfig {
   mapping?: any;
   migrationVersion?: Record<string, any>;
   path?: string;
-  searchSource?: SearchSourceContract | boolean;
+  searchSource?: SearchSource | boolean;
   type?: string;
 }