Rename alertTypeParams to params#51255
Conversation
mikecote
added
Feature:Alerting
v8.0.0
release_note:skip
|
Pinging @elastic/kibana-stack-services (Team:Stack Services) |
💔 Build Failed |
💔 Build Failed |
pmuellr
left a comment
pmuellr
left a comment
There was a problem hiding this comment.
LGTM
I think we should probably keep a "short list" somewhere of our current users - this will be a breaking change for them so we should give them a send-ahead.
This will also require a change to kbn-alert in https://github.com/pmuellr/kbn-action
💔 Build Failed |
💔 Build Failed |
|
@elasticmachine merge upstream |
💚 Build Succeeded |
|
cc @elastic/stack-monitoring & @elastic/siem upcoming breaking change in alerting. |
FrankHassanabad
left a comment
FrankHassanabad
left a comment
There was a problem hiding this comment.
Checked this out and tested it with ad-hoc e2d tests where I posted some signals, deleted them, and did find against them and everything looks ok.
Really appreciate you looking out for us @mikecote and making these changes in our code base and pinging us.
👍 LGTM
|
@elasticmachine merge upstream |
gmmorris
left a comment
gmmorris
left a comment
There was a problem hiding this comment.
LGTM
Nothing meaningful to give feedback on as it's mainly a rename and it seems to still work, so 👍
💚 Build Succeeded |
5 participants
In this PR, I'm renaming alertTypeParams to params for consistency with the attribute names within actions.
Fixes #49704.
cc @YulNaumenko as the rename will also have to change within the UI branch.
cc @FrankHassanabad as a heads up of a breaking change for SIEM PRs not yet merged. I renamed what I could of what's within master.