adds per-actionType enablement via config xpack.actions.enabledActionTypes#52967
Merged
pmuellr merged 7 commits intoelastic:masterfrom Dec 17, 2019
Merged
adds per-actionType enablement via config xpack.actions.enabledActionTypes#52967pmuellr merged 7 commits intoelastic:masterfrom
pmuellr merged 7 commits intoelastic:masterfrom
Conversation
pmuellr
added
Feature:Alerting
v8.0.0
release_note:skip
Contributor
Author
|
This still needs:
|
Contributor
|
|
mikecote
approved these changes
Dec 13, 2019
Contributor
mikecote
left a comment
mikecote
left a comment
There was a problem hiding this comment.
LGTM! 👍 Just one question and nit.
x-pack/test/alerting_api_integration/spaces_only/tests/actions/type_not_enabled.ts
Show resolved
Hide resolved
gmmorris
approved these changes
Dec 16, 2019
Contributor
gmmorris
left a comment
gmmorris
left a comment
There was a problem hiding this comment.
Made a few comments for a few small things, but overall LGTM. 👍
| actionType: string | ||
| ): boolean { | ||
| const enabled = new Set(enabledTypes); | ||
| if (enabled.has('*')) return true; |
Contributor
There was a problem hiding this comment.
Can we use the enum here?
Contributor
Author
There was a problem hiding this comment.
woops, ya, I added the enum after starting with just using literal * - should be using the enum
Contributor
|
@elasticmachine merge upstream |
pmuellr
changed the title
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
pmuellr
added a commit
to pmuellr/kibana
that referenced
this pull request
Dec 17, 2019
…Types (elastic#52967) * adds per-actionType enablement via config xpack.actions.enabledTypes resolves: elastic#52326
Contributor
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolves #52326
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11This was checked for keyboard-only and screenreader accessibilityFor maintainers
This includes a feature addition or change that requires a release note and was labeled appropriately