[7.x] [APM] Refactor & scope aggregation types (#48394)#49148
Merged
dgieselaar merged 1 commit intoelastic:7.xfrom Oct 24, 2019
Merged
[7.x] [APM] Refactor & scope aggregation types (#48394)#49148dgieselaar merged 1 commit intoelastic:7.xfrom
dgieselaar merged 1 commit intoelastic:7.xfrom
Conversation
* [APM] Refactor & scope aggregation types Iterate on the APM aggregation types, make them more readable and explicitly scope them as APM-specific. ES typings: - Refactored aggregation types (mostly better naming, slightly less hacks) - Do not add APM typings to `elasticsearch` module to explicitly scope them as APM specific - Make restTotalHitsAsInt a type option rather than a separate type - `terms` bucket key type now accounts for the fact it can be both number and string `mergeProjection`: - Type check arguments for compatibility with ESSearchRequest - Require valid aggregation objects in source parameter. Seems less brittle, and surfaces errors closer to the source Other changes: - Sort options in some cases need `as const`, type casts or type guards - Simplify types for metric aggregations * Add type casts for bucket keys in remaining places * Review feedback
Contributor
💚 Build Succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: