[SIEM] Add TLS to Network overview page by angorayc · Pull Request #48062 · elastic/kibana

angorayc · 2019-10-13T21:00:50Z

Summary

Isolating the existing TLS table from ip details page and share it with network overview page.
#47581

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
~~[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support~~
~~[ ] Documentation was added for features that require explanation or tutorials~~
Unit or functional tests were updated or added to match the most common scenarios
~~[ ] This was checked for keyboard-only and screenreader accessibility~~

For maintainers

~~[ ] This was checked for breaking API changes and was labeled appropriately~~
~~[ ] This includes a feature addition or change that requires a release note and was labeled appropriately~~

elasticmachine · 2019-10-13T21:02:27Z

Pinging @elastic/siem (Team:SIEM)

elasticmachine · 2019-10-13T22:25:52Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 5aa3c40a304d862a252f7cc779406b41d7d9b752

elasticmachine · 2019-10-14T22:41:55Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: d33a69e

stephmilovic · 2019-10-14T23:38:28Z

Right away, I think that you incorrectly resolved some conflicts. The Domains table was deleted from the repo in this PR #47608

Please ensure references to Domains are all removed

elasticmachine · 2019-10-14T23:39:26Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 8b2dde6

elasticmachine · 2019-10-15T00:26:36Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: e0f85d5

x-pack/legacy/plugins/siem/public/mock/global_state.ts

x-pack/legacy/plugins/siem/public/store/network/model.ts

x-pack/legacy/plugins/siem/server/lib/tls/index.ts

x-pack/legacy/plugins/siem/public/pages/network/navigation/tls_query_tab_body.tsx

x-pack/legacy/plugins/siem/public/store/network/reducer.ts

stephmilovic · 2019-10-15T01:49:35Z

You need to change tlsSelector in x-pack/legacy/plugins/siem/public/store/network/selectors.ts to take a networkType argument to determine which tls table state you are tracking, network page or network details. The activePage is getting set to 0 on every page load (i just introduced this but think i need another condition should only happen on ip details), but you can still see that the sort and limit are in sync from details to network when they should have independent state. Follow how this is done in topNFlowSelector

x-pack/legacy/plugins/siem/public/pages/network/navigation/tls_query_tab_body.tsx

stephmilovic · 2019-10-15T01:57:36Z

Right now, the TlsTable in x-pack/legacy/plugins/siem/public/components/page/network/tls_table/index.tsx only calls an update to networkActions.updateIpDetailsTableActivePage. It should also be able to call networkActions.updateNetworkPageTableActivePage when updating the TLS table on the network page. Add a check like in the network_top_n_flow_table to determine which updateTable you should call

elasticmachine · 2019-10-15T02:02:11Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 4309222

elasticmachine · 2019-10-15T10:11:02Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 4eff4ff

elasticmachine · 2019-10-15T11:07:18Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 5ad1af2

elasticmachine · 2019-10-15T11:47:19Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 98fa617

elasticmachine · 2019-10-15T14:45:28Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 93a0abd

stephmilovic · 2019-10-15T18:26:19Z

x-pack/legacy/plugins/siem/public/store/network/reducer.ts

    ...state,
-    [NetworkType.details]: {
-      ...state[NetworkType.details],
+    [networkType]: {


I got type errors and had to do the specific check like you see in updateTopNFlowLimit. have you run a type check here, trying to run it locally and its blowing up

stephmilovic · 2019-10-15T18:26:33Z

x-pack/legacy/plugins/siem/public/store/network/selectors.ts

  );
 };

+export const tlsSelector = (networkType: NetworkType) => {


stephmilovic · 2019-10-15T18:27:27Z

x-pack/legacy/plugins/siem/server/lib/tls/index.ts

+export interface TlsRequestOptions extends RequestOptionsPaginated {
+  ip?: string;
+  tlsSortField: TlsSortField;
+  flowTarget: FlowTarget;


Should this be FlowTargetSourceDest?

stephmilovic · 2019-10-15T18:28:17Z

x-pack/legacy/plugins/siem/public/pages/network/ip_details.tsx

                  endDate={to}
                  filterQuery={filterQuery}
-                  flowTarget={flowTarget}
+                  flowTarget={FlowTargetSourceDest.source}


this does not need to be dynamic?

stephmilovic

Performed code review, ran locally, tested manually for quite a while between the different pages, activePage, limit, and sort. Everything is running smoothly. LGTM 🚀

elasticmachine · 2019-10-15T22:17:28Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 5620fe6

elasticmachine · 2019-10-16T00:26:09Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 6aaf5e8

elasticmachine · 2019-10-16T01:50:27Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 34cb418

angorayc · 2019-10-16T01:53:25Z

jenkins, retest

angorayc · 2019-10-16T01:54:07Z

jenkins, test this

elasticmachine · 2019-10-16T03:23:49Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 34cb418

elasticmachine · 2019-10-16T06:32:41Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: d887538

* add TLS table to network overview page * isolate TLS parser * add unit test * add integration test * fix types * revert not necessary change * remove variables for domains table * fix for review * fix tlsSelector * update tls selector * apply updateTlsLimit * update selected property for tls selector * add networkType as the 2nd param of updateTlsSort * correcting pagetype * check the page type for updateTableActivePage * hard coded the targeting table name * remove tls table param as property * fix types

elasticmachine · 2019-10-30T00:29:35Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: d887538

angorayc force-pushed the newtowrk-tls branch from ecac737 to 5aa3c40 Compare October 13, 2019 21:01

angorayc added Team:SIEM v7.5.0 v8.0.0 labels Oct 13, 2019

angorayc added the release_note:enhancement label Oct 13, 2019

angorayc added 5 commits October 14, 2019 21:55

add TLS table to network overview page

2fb5029

isolate TLS parser

cc8de54

add unit test

9fd5ca9

add integration test

c05acd9

fix types

d33a69e

angorayc force-pushed the newtowrk-tls branch from 5aa3c40 to d33a69e Compare October 14, 2019 21:17

revert not necessary change

8b2dde6

Merge remote-tracking branch 'upstream/master' into newtowrk-tls

e0f85d5

remove variables for domains table

4309222

stephmilovic reviewed Oct 15, 2019

View reviewed changes

x-pack/legacy/plugins/siem/public/mock/global_state.ts Outdated Show resolved Hide resolved

stephmilovic reviewed Oct 15, 2019

View reviewed changes

x-pack/legacy/plugins/siem/public/store/network/model.ts Outdated Show resolved Hide resolved

stephmilovic reviewed Oct 15, 2019

View reviewed changes

x-pack/legacy/plugins/siem/server/lib/tls/index.ts Outdated Show resolved Hide resolved

stephmilovic reviewed Oct 15, 2019

View reviewed changes

x-pack/legacy/plugins/siem/public/pages/network/navigation/tls_query_tab_body.tsx Outdated Show resolved Hide resolved

stephmilovic reviewed Oct 15, 2019

View reviewed changes

x-pack/legacy/plugins/siem/public/store/network/reducer.ts Show resolved Hide resolved

stephmilovic reviewed Oct 15, 2019

View reviewed changes

x-pack/legacy/plugins/siem/public/pages/network/navigation/tls_query_tab_body.tsx Outdated Show resolved Hide resolved

fix for review

5c6cf25

angorayc added 2 commits October 15, 2019 10:51

correcting pagetype

5ad1af2

check the page type for updateTableActivePage

eea44a1

hard coded the targeting table name

98fa617

remove tls table param as property

93a0abd

stephmilovic reviewed Oct 15, 2019

View reviewed changes

stephmilovic requested changes Oct 15, 2019

View reviewed changes

stephmilovic approved these changes Oct 15, 2019

View reviewed changes

fix types

5620fe6

Merge remote-tracking branch 'upstream/master' into newtowrk-tls

6aaf5e8

Merge remote-tracking branch 'upstream/master' into newtowrk-tls

34cb418

Merge remote-tracking branch 'upstream/master' into newtowrk-tls

d887538

angorayc merged commit cb091e8 into elastic:master Oct 16, 2019

angorayc mentioned this pull request Oct 16, 2019

[7.x] [SIEM] Add TLS to Newtowrk overview page (#48062) #48386

Merged

MarkSettleES changed the title ~~[SIEM] Add TLS to Newtowrk overview page~~ [SIEM] Add TLS to Newtwork overview page Oct 29, 2019

MarkSettleES changed the title ~~[SIEM] Add TLS to Newtwork overview page~~ [SIEM] Add TLS to Network overview page Oct 29, 2019

Conversation

angorayc commented Oct 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Oct 13, 2019

Uh oh!

elasticmachine commented Oct 13, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Oct 14, 2019

💔 Build Failed

Uh oh!

stephmilovic commented Oct 14, 2019

Uh oh!

elasticmachine commented Oct 14, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Oct 15, 2019

💔 Build Failed

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stephmilovic commented Oct 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

stephmilovic commented Oct 15, 2019

Uh oh!

elasticmachine commented Oct 15, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Oct 15, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Oct 15, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Oct 15, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Oct 15, 2019

💚 Build Succeeded

Uh oh!

stephmilovic Oct 15, 2019

Choose a reason for hiding this comment

Uh oh!

stephmilovic Oct 15, 2019

Choose a reason for hiding this comment

Uh oh!

stephmilovic Oct 15, 2019

Choose a reason for hiding this comment

Uh oh!

stephmilovic Oct 15, 2019

Choose a reason for hiding this comment

Uh oh!

stephmilovic left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Oct 15, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Oct 16, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Oct 16, 2019

💔 Build Failed

Uh oh!

angorayc commented Oct 16, 2019

Uh oh!

angorayc commented Oct 16, 2019

Uh oh!

elasticmachine commented Oct 16, 2019

💚 Build Succeeded

Uh oh!

angorayc commented Oct 13, 2019 •

edited

Loading

stephmilovic commented Oct 15, 2019 •

edited

Loading