[SIEM] Source/Destination Ip Table on Ip Details#47608
[SIEM] Source/Destination Ip Table on Ip Details#47608stephmilovic merged 18 commits intoelastic:masterfrom
Conversation
💚 Build Succeeded |
|
Pinging @elastic/siem (Team:SIEM) |
💚 Build Succeeded |
💚 Build Succeeded |
| let tableType: networkModel.TopNTableType; | ||
| let headerTitle: string; | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any |
There was a problem hiding this comment.
if anyone can help figure out this type... wrestled with it for too long on my own
There was a problem hiding this comment.
let updateTableActivePage: NetworkTopNFlowTableDispatchProps["updateIpDetailsTableActivePage"] | NetworkTopNFlowTableDispatchProps["updateNetworkPageTableActivePage"]; maybe?
There was a problem hiding this comment.
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
|
@stephmilovic Imho, the autonomous system column, which is most of the time empty takes too much horizontal space.. Maybe rename to AS? |
|
Sorry for looking at this so late. I think we can remove the last column (Source/Destination IPs). Since this is on the IP Details page, it will always be |
makes sense to me, but lets see what @cwurm thinks |
💚 Build Succeeded |
x-pack/legacy/plugins/siem/public/components/page/network/network_top_n_flow_table/columns.tsx
Outdated
Show resolved
Hide resolved
| activePage: number; | ||
| tableType: networkModel.IpDetailsTableType; | ||
| }>; | ||
| updateNetworkPageTableActivePage: ActionCreator<{ |
There was a problem hiding this comment.
Instead of having separate actions for each page, consolidating to a single action that also takes NetworkType should simplify the logic and make it simpler to add this component to another page in the future. Should take care of the typing issue below as well! As above the Authentications table has a good example of this:
There was a problem hiding this comment.
having type issues trying to implement this. the reason we dont have the same issue in hosts is because they display the same table, where as there is a difference between network and ip details
There was a problem hiding this comment.
@spong and i paired on this a while today, thought we came up with a solution but it was a farce! Reconvening Monday
💚 Build Succeeded |
💚 Build Succeeded |
💔 Build Failed |
💚 Build Succeeded |
x-pack/legacy/plugins/siem/public/components/page/network/network_top_n_flow_table/columns.tsx
Outdated
Show resolved
Hide resolved
spong
left a comment
spong
left a comment
There was a problem hiding this comment.
Checked out, tested locally, and performed code review.
Thanks for taking the time to clean up our typings and making it even easier to use the Source/Destination tables on new pages in the future LGTM! 👍
💚 Build Succeeded |
6 participants
Summary
Resolves #44777
Implements source and destination IP table on the IP Details page, and removes the Domains table. Added an option argument to the
NetworkTopNFlowQueryto filter byip.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsThis was checked for keyboard-only and screenreader accessibilityFor maintainers
This was checked for breaking API changes and was labeled appropriatelyThis includes a feature addition or change that requires a release note and was labeled appropriately