Skip to content

Removing default title from saving a new search in Discover #47031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
majagrubic merged 1 commit into from
Oct 2, 2019
Merged

Removing default title from saving a new search in Discover #47031

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/legacy/core_plugins/kibana/public/discover/saved_searches/_saved_search.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
*/

import 'ui/notify';
import { i18n } from '@kbn/i18n';
import { uiModules } from 'ui/modules';
import { createLegacyClass } from 'ui/utils/legacy_class';
import { SavedObjectProvider } from 'ui/saved_objects/saved_object';
Expand All @@ -38,9 +37,7 @@ module.factory('SavedSearch', function (Private) {

id: id,
defaults: {
title: i18n.translate('kbn.discover.savedSearch.newSavedSearchTitle', {
defaultMessage: 'New Saved Search',
}),
title: '',
description: '',
columns: [],
hits: 0,
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/ja-JP.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1581,7 +1581,6 @@
"kbn.discover.notifications.savedSearchTitle": "検索「{savedSearchTitle}」が保存されました。",
"kbn.discover.painlessError.painlessScriptedFieldErrorMessage": "Painless スクリプトのフィールド「{script}」のエラー.",
"kbn.discover.rootBreadcrumb": "ディスカバリ",
"kbn.discover.savedSearch.newSavedSearchTitle": "新しく保存された検索",
"kbn.discover.savedSearch.savedObjectName": "保存された検索",
"kbn.discover.scaledToDescription": "{bucketIntervalDescription} にスケーリング済み",
"kbn.discover.searchingTitle": "検索中",
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/zh-CN.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1582,7 +1582,6 @@
"kbn.discover.notifications.savedSearchTitle": "搜索 “{savedSearchTitle}” 已保存",
"kbn.discover.painlessError.painlessScriptedFieldErrorMessage": "Painless 脚本字段 “{script}” 有错误。",
"kbn.discover.rootBreadcrumb": "Discover",
"kbn.discover.savedSearch.newSavedSearchTitle": "新保存的搜索",
"kbn.discover.savedSearch.savedObjectName": "已保存搜索",
"kbn.discover.scaledToDescription": "已缩放至 {bucketIntervalDescription}",
"kbn.discover.searchingTitle": "正在搜索",
Expand Down