Removing default title from saving a new search in Discover#47031
Merged
majagrubic merged 1 commit intoelastic:masterfrom Oct 2, 2019
Merged
Removing default title from saving a new search in Discover#47031majagrubic merged 1 commit intoelastic:masterfrom
majagrubic merged 1 commit intoelastic:masterfrom
Conversation
Contributor
💔 Build Failed |
majagrubic
force-pushed
the
maja/discover-title
branch
from
6ee641c to
262d910
Compare
Contributor
💚 Build Succeeded |
majagrubic
added
Feature:Discover
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
majagrubic
added
release_note:skip
flash1293
approved these changes
Oct 2, 2019
Contributor
flash1293
left a comment
flash1293
left a comment
There was a problem hiding this comment.
Tested and works 👍 While you are at it, Graph could also use this :)
majagrubic
pushed a commit
to majagrubic/kibana
that referenced
this pull request
Oct 4, 2019
majagrubic
pushed a commit
that referenced
this pull request
Oct 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a continuation of: #46719
This PR removes a default search title in Discover.
Before:
After:
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.~~ [ ] This was checked for cross-browser compatibility, including a check against IE11~~
[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorialsFor maintainers